Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the icon preview page to its glory #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpetazzo
Copy link

@jpetazzo jpetazzo commented Dec 3, 2022

I wanted to see all the nice emojis, but the preview page was broken, so... here we go!

Feel free to discard that PR if it's useless (perhaps you have a better way to preview these icons anyway). Also, I couldn't find a clean way to set the image size, because apparently the only way to set the image size is with <img> tags, but the only way to get relative links is to use [](), so ... 🤷🏻

@penguineer
Copy link

This sounds like something that could be done with a GitHub action and live on an extra branch for a GitHub page. 😎

(Just dumping an idea. If I find the time, I'll hand in a PR.)

@quintessence
Copy link
Owner

Ah yeah - part of the reason I took down the preview page is because I felt that the iconset was getting too large. If there's interest perhaps I'll have one generated in the different subdirectories?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants