Allow for multi-dimensional arrays in FROM-ARRAY constructor. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any number of dimensions are supported, however the input layout MUST be row-major. Input array is now copied.
notmgsk
suggested changes
Apr 21, 2020
stylewarning
requested changes
Apr 24, 2020
- Add INPUT-LAYOUT and code to copy arrays in the correct order. - Update all existing references to FROM-ARRAY to reflect changes. - Squash a particularly nasty bug where INV would output would have the wrong layout when input is ROW-MAJOR.
- Add tests for FROM-ARRAY with varying dimensions and layouts
|
All the outstanding issues (hopefully) have been resolved. As a bonus I squashed a bug caused by |
notmgsk
suggested changes
May 6, 2020
|
|
notmgsk
approved these changes
May 15, 2020
stylewarning
approved these changes
May 29, 2020
|
Sorry all, especially @colescott, for the delay in approving. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for multi-dimensional arrays as input to
FROM-ARRAY(Resolves #102)This also adds a new kw arg to
FROM-ARRAY,INPUT-LAYOUTwhich allows for reindexing of input arrays (INPUT-LAYOUTdoes not need to be the same asLAYOUT).As a bonus, fixes a bug that came up while testing this PR caused by
LAPACK-INVnot setting the layout of the tensor toCOLUMN-MAJORafter fortran touched it.