allow specifying index in otel http protobuf api #5421
Conversation
There was a problem hiding this comment.
An entry in the docs (https://quickwit.io/docs/main-branch/log-management/otel-service and https://quickwit.io/docs/main-branch/distributed-tracing/otel-service) would be cool! I remember struggling to figure out the exact endpoint when setting up OTEL ingestion with Grafana Tempo 😄
| #[utoipa::path( | ||
| post, | ||
| tag = "Open Telemetry", | ||
| path = "/{index}/otlp/v1/traces", |
There was a problem hiding this comment.
I'm a bit surprised that we use a path param here and not a header (also what was suggested in #5413). It would be more in line with the way it works in GRPC. But of course in GRPC you don't have a path, so the comparison doesn't really hold. I guess both are fine!
There was a problem hiding this comment.
That api endpoint was already there (but didn't work properly and was absent from openapi definiton). @fmassot, looks like that code was yours, what do you think (index in path vs in header)?
Description
fix #5413
How was this PR tested?
updated tests