Solving warn received an empty publish shard positions update.
#4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
approved these changes
Apr 25, 2024
| .collect::<Vec<_>>(); | ||
| // This can happen if the shards have been deleted by the control plane, after building | ||
| // the plan and before the apply terminated. See #4888s. | ||
| info!(missing_shards=?missing_shards, "failed to acquire all requested shards"); |
There was a problem hiding this comment.
Suggested change
| info!(missing_shards=?missing_shards, "failed to acquire all requested shards"); | |
| info!(missing_shards=?missing_shards, "failed to acquire all assigned shards"); |
| }) | ||
| .collect::<Vec<_>>(); | ||
| // This can happen if the shards have been deleted by the control plane, after building | ||
| // the plan and before the apply terminated. See #4888s. |
There was a problem hiding this comment.
Suggested change
| // the plan and before the apply terminated. See #4888s. | |
| // the plan and before the apply terminated. See #4888. |
| @@ -599,7 +616,10 @@ impl Source for IngestSource { | |||
| }; | |||
| self.assigned_shards.insert(shard_id, assigned_shard); | |||
| } | |||
| self.truncate(truncate_up_to_positions).await; | |||
|
|
|||
| if !truncate_up_to_positions.is_empty() { | |||
There was a problem hiding this comment.
We could nest this !truncate_up_to_positions.is_empty() into truncate(...) directly, and remove those checks elsewhere. That would make it much easier to test that we don't send empty truncates.
fulmicoton
force-pushed
the
issue/4888-empty-publish-shard-positions-update-warning
branch
3 times, most recently
from
740fd95
to
e843726
Compare
This should remove all warn logging `received an empty publish shard positions update`. We also start logging an info showing highlighting the race condition that was causing this warning log. Closes #4888
|
I added a unit test in the ingest source, extended the unit test in the metastore suite, and added documentation on the spec of the metastore. |
fulmicoton
force-pushed
the
issue/4888-empty-publish-shard-positions-update-warning
branch
from
e843726
to
da2501d
Compare
fulmicoton
deleted the
issue/4888-empty-publish-shard-positions-update-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove all warn logging
received an empty publish shard positions update. We also start logging an info showing highlighting the race condition that was causing this warning log.Closes #4888