Allow naming tasks to differentiate actors in tokio-console. #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, tokio-console labels its task using its spawning point. Since all actors are spawned from the same place they end up with the same label. This introduce an API to optionally name tasks. For actors, the actor's struct Name is used automatically. If tokio-console is not enabled, this is no cost.
trinity-1686a
approved these changes
Jan 24, 2024
By default, tokio-console labels its task using its spawning point. Since all actors are spawned from the same place they end up with the same label. This introduce an API to optionally name tasks. For actors, the actor's struct Name is used automatically. If tokio-console is not enabled, this is no cost.
fulmicoton
force-pushed
the
named_tasks
branch
from
8046fcd
to
f305c7f
Compare
fulmicoton
force-pushed
the
named_tasks
branch
from
f305c7f
to
79c6e27
Compare
fulmicoton
force-pushed
the
named_tasks
branch
from
c044bc0
to
a04c7ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, tokio-console labels its task using its spawning point. Since all actors are spawned from the same place they end up with the same label.
This introduce an API to optionally name tasks.
For actors, the actor's struct Name is used automatically.
If tokio-console is not enabled, this is no cost.