-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debouncing reschedule. #4416
Merged
Merged
Debouncing reschedule. #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/4407-debounce-reschedule
branch
3 times, most recently
from
January 18, 2024 13:00
6314bf4
to
35bca11
Compare
fulmicoton
force-pushed
the
issue/4407-debounce-reschedule
branch
from
January 18, 2024 13:46
0ec0c7d
to
7208edb
Compare
guilload
reviewed
Jan 18, 2024
fulmicoton
force-pushed
the
issue/4407-debounce-reschedule
branch
3 times, most recently
from
January 19, 2024 07:47
43693e5
to
37a1593
Compare
After this change, the creation of a new plan will happen at most once by window of 5s. Outside of cooldown period, a (relevant) event triggers a RebuildPlan instant. Limiting concurrency of the Metastore client using a tower Layer. Closes #4407 Co-authored-by: Adrien Guillo <[email protected]> cool_down -> cooldown
fulmicoton
force-pushed
the
issue/4407-debounce-reschedule
branch
from
January 19, 2024 08:10
37a1593
to
bdacb11
Compare
guilload
approved these changes
Jan 22, 2024
Co-authored-by: Adrien Guillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, the creation of a new plan will happen at most once by window of 5s. Outside of cooldown period, a (relevant) event triggers a RebuildPlan instant.
Related to #4407