Removing planing loop #3913
Merged
Removing planing loop #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two internal actors are replaced by two internal states. Their execution is not concurrent anymore, but we the code and the flow is simplified and we avoid some race conditions. The control plane is not getting the update notify signal through the broker anymore. The Notify RPC is entirely removed. Most of the test in the indexer scheduler become Control plane tests.
The RefreshPlan loop is not necessary since after we moved to the control plane as a metastore proxy world, the control plan cannot miss any Index/Source event.
fulmicoton
force-pushed
the
removing-planing-loop
branch
from
d17bfae
to
619e5ae
Compare
guilload
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.