-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC for ssd cache #3723
Closed
Closed
POC for ssd cache #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Aug 11, 2023
fulmicoton
reviewed
Aug 11, 2023
quickwit/quickwit-control-plane/src/cache_storage_controller.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Aug 11, 2023
quickwit/quickwit-control-plane/src/cache_storage_controller.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Aug 11, 2023
quickwit/quickwit-control-plane/src/cache_storage_controller.rs
Outdated
Show resolved
Hide resolved
fulmicoton
force-pushed
the
issue/3443-ssd-cache
branch
from
August 15, 2023 07:30
90540f9
to
05cba39
Compare
imotov
force-pushed
the
issue/3443-ssd-cache
branch
3 times, most recently
from
August 18, 2023 03:40
9bf68cb
to
ea172ae
Compare
Co-authored-by: Paul Masurel <[email protected]>
Co-authored-by: Paul Masurel <[email protected]>
Co-authored-by: Paul Masurel <[email protected]>
WIP, still needs tests, throttling and handling of node restart.
That should help with adding tests.
Also adds an integration test to ensure that it works end-to-end.
imotov
force-pushed
the
issue/3443-ssd-cache
branch
from
August 19, 2023 03:34
ea172ae
to
84db9e2
Compare
Cache storage is resolved only onced and cached. Cache uri is a Uri. Counters are not copied all over the place. The Factory one was actually disconnected from the rest. Removed redundant `Arc` indirection
fulmicoton
force-pushed
the
issue/3443-ssd-cache
branch
from
August 21, 2023 14:06
7ce7cb4
to
bd28308
Compare
In this step we just change the way CacheStorageService is getting access to CachedSplitRegistry.
Superseded by #3786 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proof of concept for adding SSD cache to make sure this architecture is feasible. It is still in the very early stages, not all features are implemented.
To setup add the following node configuration is needed:
On the index side the following setting should be added to the config:
Fixes #3443
How was this PR tested?
Still need to add tests.
Outstanding issues
This is still WIP. The following tasks are still need to be finished for MVP:
cache:file:///tmp
Beyond MVP: