Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster info endpoint for /_elastic #3594

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Add cluster info endpoint for /_elastic #3594

merged 6 commits into from
Jul 5, 2023

Conversation

evanxg852000
Copy link
Collaborator

@evanxg852000 evanxg852000 commented Jun 29, 2023 •
edited
Loading

@evanxg852000 evanxg852000 changed the title Add cluster info endpoint for _elastic Add cluster info endpoint for /_elastic Jun 29, 2023
@evanxg852000 evanxg852000 force-pushed the evance--add-elastic-compat-cluster-info-endpoint branch 2 times, most recently from cb35e38 to 13dcd2a Compare June 29, 2023 18:09
@evanxg852000 evanxg852000 force-pushed the evance--add-elastic-compat-cluster-info-endpoint branch from 13dcd2a to de78578 Compare June 30, 2023 06:58
@evanxg852000 evanxg852000 marked this pull request as ready for review June 30, 2023 06:59
fmassot
fmassot reviewed Jun 30, 2023
View reviewed changes
quickwit/quickwit-serve/src/node_info_handler.rs Outdated
node_version_handler(build_info, runtime_info).or(node_config_handler(config))
node_version_handler(build_info, runtime_info)
.or(node_config_handler(config.clone()))
.or(es_compat_info_handler(build_info, config))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the place to put ES handler right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are the top-level handlers for cluster info. That's why it is built in ES folder but mounted here. functionally they belong to the same group. But I can just mount it there if you think this is more appropriate to you.

Copy link
Contributor

@fmassot fmassot Jun 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we want to keep all elasticsearch handlers mounted at the same place, under the _elastic path, that's the current logic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed to mount all elastic-related endpoints from the same location.

@evanxg852000 evanxg852000 force-pushed the evance--add-elastic-compat-cluster-info-endpoint branch from 5275593 to a038a05 Compare June 30, 2023 16:31
@evanxg852000 evanxg852000 force-pushed the evance--add-elastic-compat-cluster-info-endpoint branch from a038a05 to 2e39321 Compare June 30, 2023 16:42
@fulmicoton
Copy link
Contributor

Can we add a rest-api test for this? It is (hopefully) relatively easy https://github.com/quickwit-oss/quickwit/blob/main/quickwit/rest-api-tests/README.md

fmassot
fmassot approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evanxg852000 evanxg852000 merged commit ae768bf into main Jul 5, 2023
7 checks passed
@evanxg852000 evanxg852000 deleted the evance--add-elastic-compat-cluster-info-endpoint branch July 5, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET on /api/v1/_elastic should return basic info of the cluster
3 participants
@evanxg852000 @fulmicoton @fmassot