Add some logging statements

quickwit/quickwit-indexing/src/actors/indexing_service.rs

@@ -387,6 +387,11 @@ impl IndexingService {
         ctx: &ActorContext<Self>,
         indexing_pipeline_ids: &[IndexingPipelineId],
     ) -> Result<Vec<IndexMetadata>, IndexingError> {
+        info!(
+            "fetching {} indexes metadata for indexing pipelines `{}`",
+            indexing_pipeline_ids.len(),
+            indexing_pipeline_ids.iter().join(", ")
+        );
         let index_metadata_subrequests: Vec<IndexMetadataSubrequest> = indexing_pipeline_ids
             .iter()
             // Remove duplicate subrequests
@@ -399,15 +404,31 @@ impl IndexingService {
         let indexes_metadata_request = IndexesMetadataRequest {
             subrequests: index_metadata_subrequests,
         };
+        info!(
+            "issuing request with {} subrequests: {:?}",
+            indexes_metadata_request.subrequests.len(),
+            indexes_metadata_request
+        );
         let _protected_zone_guard = ctx.protect_zone();
 
         let indexes_metadata_response = self
             .metastore
             .indexes_metadata(indexes_metadata_request)
             .await?;
+        if !indexes_metadata_response.failures.is_empty() {
+            error!(
+                "received IndexesMetadataResponse with {} failures: {:?}",
+                indexes_metadata_response.failures.len(),
+                indexes_metadata_response.failures
+            );
+        }
         let indexes_metadata = indexes_metadata_response
             .deserialize_indexes_metadata()
             .await?;
+        info!(
+            "received response with {} indexes metadata",
+            indexes_metadata.len(),
+        );
         Ok(indexes_metadata)
     }
 
@@ -550,6 +571,9 @@ impl IndexingService {
                 }
             })
             .collect();
+        if pipeline_ids_to_add.is_empty() {
+            return Ok(Vec::new());
+        }
         self.spawn_pipelines(&pipeline_ids_to_add, ctx).await
     }
 

quickwit/quickwit-metastore/src/metastore/mod.rs

@@ -256,7 +256,7 @@ impl IndexMetadataResponseExt for IndexMetadataResponse {
     }
 }
 
-/// Helper trait to build a `ListIndexesResponse` and deserialize its payload.
+/// Helper trait to build a [`IndexesMetadataResponse`] and deserialize its payload.
 #[async_trait]
 pub trait IndexesMetadataResponseExt {
     /// Creates a new `IndexesMetadataResponse` from a `Vec` of [`IndexMetadata`].