Remove seed resolution validation (#4688)

* Remove seed resolution validation * Add extra warning when failing to resolve all seeds
quickwit-oss · Mar 7, 2024 · cd96a3c · cd96a3c
1 parent 5783cc7
commit cd96a3c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/quickwit/quickwit-config/src/node_config/mod.rs b/quickwit/quickwit-config/src/node_config/mod.rs
@@ -459,10 +459,7 @@ impl NodeConfig {
             peer_seed_addrs.push(peer_seed_addr.to_string())
         }
         if !self.peer_seeds.is_empty() && peer_seed_addrs.is_empty() {
-            bail!(
-                "failed to resolve any of the peer seed addresses: `{}`",
-                self.peer_seeds.join(", ")
-            )
+            warn!("failed to resolve all the peer seed addresses")
         }
         Ok(peer_seed_addrs)
     }

diff --git a/quickwit/quickwit-config/src/node_config/serialize.rs b/quickwit/quickwit-config/src/node_config/serialize.rs
@@ -863,16 +863,6 @@ mod tests {
             .unwrap();
             assert!(node_config.peer_seed_addrs().await.unwrap().is_empty());
         }
-        {
-            let node_config = NodeConfigBuilder {
-                peer_seeds: ConfigValue::for_test(List(vec!["unresolvable-host".to_string()])),
-                ..Default::default()
-            }
-            .build_and_validate(&HashMap::new())
-            .await
-            .unwrap();
-            assert!(node_config.peer_seed_addrs().await.is_err());
-        }
         {
             let node_config = NodeConfigBuilder {
                 rest_config_builder: RestConfigBuilder {