Stop recording deltas when already EOF

quickwit-oss · Aug 20, 2024 · bcf39c0 · bcf39c0
1 parent 2368c07
commit bcf39c0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/quickwit/quickwit-cli/tests/cli.rs b/quickwit/quickwit-cli/tests/cli.rs
@@ -286,7 +286,7 @@ async fn test_ingest_docs_cli() {
 }
 
 #[tokio::test]
-async fn test_ingest_docs_cli_twice() {
+async fn test_reingest_same_file_cli() {
     quickwit_common::setup_logging_for_tests();
     let index_id = append_random_suffix("test-index-simple");
     let test_env = create_test_env(index_id.clone(), TestStorageType::LocalFileSystem)

diff --git a/quickwit/quickwit-indexing/src/source/doc_file_reader.rs b/quickwit/quickwit-indexing/src/source/doc_file_reader.rs
@@ -190,9 +190,12 @@ impl ObjectUriBatchReader {
         source_progress: &Progress,
         source_type: SourceType,
     ) -> anyhow::Result<BatchBuilder> {
+        let mut batch_builder = BatchBuilder::new(source_type);
+        if self.is_eof {
+            return Ok(batch_builder);
+        }
         let limit_num_bytes = self.current_offset + BATCH_NUM_BYTES_LIMIT as usize;
         let mut new_offset = self.current_offset;
-        let mut batch_builder = BatchBuilder::new(source_type);
         while new_offset < limit_num_bytes {
             if let Some(record) = source_progress
                 .protect_future(self.reader.next_record())