Skip to content

Commit

Permalink
fix record progress
Browse files Browse the repository at this point in the history
  • Loading branch information
smiklos committed Aug 3, 2023
1 parent 7d78bf3 commit 98003e6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
6 changes: 3 additions & 3 deletions quickwit/quickwit-index-management/src/garbage_collection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,9 @@ pub async fn delete_splits_from_storage_and_metastore(
.collect::<Vec<&Path>>();
let delete_result = protect_future(progress_opt, storage.bulk_delete(&split_paths)).await;

// if let Some(ctx) = ctx_opt {
// ctx.record_progress();
// }
if let Some(progress) = progress_opt {
progress.record_progress();
}
let mut successes = Vec::with_capacity(split_infos.len());
let mut storage_error: Option<BulkDeleteError> = None;
let mut storage_failures = Vec::new();
Expand Down
5 changes: 4 additions & 1 deletion quickwit/quickwit-index-management/src/index.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ use quickwit_storage::{StorageResolver, StorageResolverError};
use thiserror::Error;
use tracing::{error, info};

use crate::garbage_collection::*;
use crate::garbage_collection::{
delete_splits_from_storage_and_metastore, run_garbage_collect, DeleteSplitsError,
SplitRemovalInfo,
};

#[derive(Error, Debug)]
pub enum IndexServiceError {
Expand Down

0 comments on commit 98003e6

Please sign in to comment.