Skip to content

Commit

Permalink
Replace action-rs/toolchain with manual config (#3834)
Browse files Browse the repository at this point in the history
* Replace action-rs/toolchain with manual config

* Run CI workflow if workflow itself changed

* Fine tune rustup setup

* Fix typo in override toolchain

* Remove toolchain override
  • Loading branch information
rdettai authored Sep 21, 2023
1 parent 46a4dc4 commit 66c8e4f
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 18 deletions.
8 changes: 3 additions & 5 deletions .github/actions/cargo-build-macos-binary/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@ runs:
- name: Install protoc
run: brew install protobuf
shell: bash
- uses: actions-rs/toolchain@v1
with:
toolchain: stable
targets: ${{ inputs.target }}
override: true
- name: Install rustup
shell: bash
run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain none -y
- name: Add target aarch64-apple-darwin
if: "${{ inputs.target == 'aarch64-apple-darwin' }}"
run: rustup target add aarch64-apple-darwin
Expand Down
8 changes: 3 additions & 5 deletions .github/actions/cross-build-binary/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@ runs:
cache-dependency-path: quickwit/quickwit-ui/yarn.lock
- run: make build-ui
shell: bash
- uses: actions-rs/toolchain@v1
with:
toolchain: stable
target: ${{ inputs.target }}
override: true
- name: Install rustup
shell: bash
run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain none -y
- name: Install cross
run: cargo install cross
shell: bash
Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,12 @@ jobs:
- quickwit/**/*.toml
- quickwit/**/*.proto
- quickwit/rest-api-tests/**
- .github/workflows/ci.yml
# The following step is just meant to install rustup actually.
# The next one installs the correct toolchain.
- name: Install rustup
uses: actions-rs/toolchain@v1
if: steps.modified.outputs.rust_src == 'true'
with:
toolchain: 1.70
components: ""
run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain none -y
- name: Setup stable Rust Toolchain
if: steps.modified.outputs.rust_src == 'true'
run: rustup show
Expand Down Expand Up @@ -106,15 +104,16 @@ jobs:
- quickwit/**/*.rs
- quickwit/**/*.toml
- quickwit/**/*.proto
- .github/workflows/ci.yml
- name: Install Ubuntu packages
if: always() && steps.modified.outputs.rust_src == 'true'
run: sudo apt-get -y install protobuf-compiler python3 python3-pip
- name: Install rustup
if: steps.modified.outputs.rust_src == 'true'
run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain none -y
- name: Setup nightly Rust Toolchain (for rustfmt)
uses: actions-rs/toolchain@v1
if: steps.modified.outputs.rust_src == 'true'
with:
toolchain: nightly
components: rustfmt
run: rustup toolchain install nightly
- name: Setup stable Rust Toolchain
if: steps.modified.outputs.rust_src == 'true'
run: rustup show
Expand Down

0 comments on commit 66c8e4f

Please sign in to comment.