Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Adrien "Code Monkey" Guillo <[email protected]>
  • Loading branch information
fulmicoton and guilload committed Feb 26, 2024
1 parent 496ec2f commit 5721c7f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions quickwit/quickwit-indexing/src/models/shard_positions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,11 @@ impl Actor for ShardPositionsService {
.await,
);

// We are now listening to new updates. However the cluster has been started earlier.
// We are now listening to new updates. However, the cluster has been started earlier.
// It might have already received shard updates from other nodes.
//
// Let's also sync our `ShardPositionsService` with the current state of the cluster.
// Shard positions update are trivially idempotent, so we can just replay all the events,
// Shard position updates are trivially idempotent, so we can replay all the events,
// without worrying about duplicates.

let now = Instant::now();
Expand Down
2 changes: 1 addition & 1 deletion quickwit/quickwit-serve/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ fn start_shard_positions_service(
spawn_ctx: SpawnContext,
) {
// We spawn a task here, because we need the ingester to be ready before spawning the
// the `ShardPositionsService`. If we don't all, all of the event we emit will be dismissed.
// the `ShardPositionsService`. If we don't, all the events we emit too early will be dismissed.
tokio::spawn(async move {
if let Some(ingester_service) = ingester_service_opt {
if wait_for_ingester_status(ingester_service, IngesterStatus::Ready)
Expand Down

0 comments on commit 5721c7f

Please sign in to comment.