Skip to content

Commit

Permalink
Enrich root/leaf search spans with number of docs and splits (#5450)
Browse files Browse the repository at this point in the history
  • Loading branch information
guilload authored Sep 26, 2024
1 parent 3d4a22c commit 450f26a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
10 changes: 8 additions & 2 deletions quickwit/quickwit-search/src/leaf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,13 @@ pub async fn leaf_search(
doc_mapper: Arc<dyn DocMapper>,
aggregations_limits: AggregationLimitsGuard,
) -> Result<LeafSearchResponse, SearchError> {
info!(splits_num = splits.len(), split_offsets = ?PrettySample::new(&splits, 5));
let num_docs: u64 = splits.iter().map(|split| split.num_docs).sum();
let num_splits = splits.len();
let current_span = tracing::Span::current();
current_span.record("num_docs", num_docs);
current_span.record("num_splits", num_splits);

info!(num_docs, num_splits, split_offsets = ?PrettySample::new(&splits, 5));

let split_filter = CanSplitDoBetter::from_request(&request, doc_mapper.timestamp_field_name());
let split_with_req = split_filter.optimize(request.clone(), splits)?;
Expand Down Expand Up @@ -1307,7 +1313,7 @@ pub async fn leaf_search(
}

#[allow(clippy::too_many_arguments)]
#[instrument(skip_all, fields(split_id = split.split_id))]
#[instrument(skip_all, fields(split_id = split.split_id, num_docs = split.num_docs))]
async fn leaf_search_single_split_wrapper(
request: SearchRequest,
searcher_context: Arc<SearcherContext>,
Expand Down
6 changes: 6 additions & 0 deletions quickwit/quickwit-search/src/root.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1120,6 +1120,12 @@ pub async fn root_search(
)
.await?;

let num_docs: usize = split_metadatas.iter().map(|split| split.num_docs).sum();
let num_splits = split_metadatas.len();
let current_span = tracing::Span::current();
current_span.record("num_docs", num_docs);
current_span.record("num_splits", num_splits);

let mut search_response = root_search_aux(
searcher_context,
&request_metadata.indexes_meta_for_leaf_search,
Expand Down

0 comments on commit 450f26a

Please sign in to comment.