As spotted by @guilload, we need to sort shards in indexing tasks. (#…

…4380)
quickwit-oss · Jan 15, 2024 · 2251e93 · 2251e93
1 parent 2c21350
commit 2251e93
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/quickwit/quickwit-control-plane/src/indexing_plan.rs b/quickwit/quickwit-control-plane/src/indexing_plan.rs
@@ -66,6 +66,9 @@ impl PhysicalIndexingPlan {
 
     pub fn normalize(&mut self) {
         for tasks in self.indexing_tasks_per_indexer_id.values_mut() {
+            for task in tasks.iter_mut() {
+                task.shard_ids.sort_unstable();
+            }
             tasks.sort_by(|left, right| {
                 left.index_uid
                     .cmp(&right.index_uid)

diff --git a/quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/mod.rs b/quickwit/quickwit-control-plane/src/indexing_scheduler/scheduling/mod.rs
@@ -92,7 +92,7 @@ impl<'a> IdToOrdMap<'a> {
             .source_uid_to_source_ord
             .insert(source.source_uid.clone(), source_ord);
         assert!(previous_item.is_none());
-        self.sources.push(&source);
+        self.sources.push(source);
         source_ord
     }