Simplify NodeConfig serialize

quickwit-oss · Aug 26, 2024 · 162f744 · 162f744
1 parent 4e45cba
commit 162f744
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/quickwit/quickwit-config/src/node_config/mod.rs b/quickwit/quickwit-config/src/node_config/mod.rs
@@ -480,9 +480,12 @@ impl NodeConfig {
         self.storage_configs.redact();
     }
 
+    /// Creates a config with defaults suitable for testing.
+    ///
+    /// Uses the default ports without ensuring that they are available.
     #[cfg(any(test, feature = "testsuite"))]
     pub fn for_test() -> Self {
-        serialize::node_config_for_tests()
+        serialize::node_config_for_tests_from_ports(7280, 7281)
     }
 
     #[cfg(any(test, feature = "testsuite"))]

diff --git a/quickwit/quickwit-config/src/node_config/serialize.rs b/quickwit/quickwit-config/src/node_config/serialize.rs
@@ -467,15 +467,6 @@ pub fn node_config_for_tests_from_ports(
     }
 }
 
-/// Creates a config with defaults that are suitable for testing.
-///
-/// Uses the default ports without ensuring that they are available.
-#[cfg(any(test, feature = "testsuite"))]
-pub fn node_config_for_tests() -> NodeConfig {
-    let default_rest = default_rest_listen_port();
-    node_config_for_tests_from_ports(default_rest, default_rest + 1)
-}
-
 #[cfg(test)]
 mod tests {
     use std::env;