-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
working examples of builds for customisation #1
base: main
Are you sure you want to change the base?
Conversation
…then delete from main
Add files via upload
…w the directory to be uploaded using github web ui
renamed .github directory that had been deliberately misnamed to allo…
Update GitHub actions
@chrjohn Hi, in github actions using "mvnw" failed and so did "mvn". Could you please advise me and I will try to correct ? |
Sorry only have access to mail right now.
I think you need to copy the mvnw files and .mvn directory from the quickfixj project.
|
working on maven in github actions, snapshot dependencies prevent the build from working but the change is an improvement
That improved it, the actions look more correct now. Build fails on snapshot dependencies though, that's one for another day. |
Where do you see the actions, though? Can't see them on this PR.
|
https://github.com/david-gibbs-ig/quickfixj-custom-orchestration-examples/actions |
I checked the settings and actions are activated and allowed. Probably they will only show in PRs once there is an action already defined on the repo.... I just copied your codeql workflow into the repo and now the actions are shown here in the PR. Re snapshot repo: I briefly investigated this myself in quickfix-j/quickfixj#769 (comment) . You can only upload a SNAPSHOT to Maven Central once. We could probably do it using github packages but I haven't had time to investigate this further. |
I replied to quickfix-j/quickfixj#769, I think the practical way to verify this pr , is to build qfj and the examples project locally. |
Fix50sp2 from orchestra
No description provided.