Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working examples of builds for customisation #1

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

david-gibbs-ig
Copy link

No description provided.

@david-gibbs-ig
Copy link
Author

@chrjohn Hi, in github actions using "mvnw" failed and so did "mvn". Could you please advise me and I will try to correct ?

@chrjohn
Copy link
Member

chrjohn commented Sep 21, 2024 via email

david-gibbs-ig and others added 2 commits September 22, 2024 13:03
working on maven in github actions, snapshot dependencies prevent the build from working but the change is an improvement
@david-gibbs-ig
Copy link
Author

Sorry only have access to mail right now. I think you need to copy the mvnw files and .mvn directory from the quickfixj project.

That improved it, the actions look more correct now. Build fails on snapshot dependencies though, that's one for another day.

@chrjohn
Copy link
Member

chrjohn commented Sep 22, 2024 via email

@david-gibbs-ig
Copy link
Author

https://github.com/david-gibbs-ig/quickfixj-custom-orchestration-examples/actions
You may need to turn them on for the quickfixj upstream repo.
P.S. To work across multiple projects it can help if there is way to publish snaphots to a mvn central snapshot repo.

@chrjohn chrjohn closed this Sep 23, 2024
@chrjohn chrjohn reopened this Sep 23, 2024
@chrjohn
Copy link
Member

chrjohn commented Sep 23, 2024

I checked the settings and actions are activated and allowed. Probably they will only show in PRs once there is an action already defined on the repo.... I just copied your codeql workflow into the repo and now the actions are shown here in the PR.

Re snapshot repo: I briefly investigated this myself in quickfix-j/quickfixj#769 (comment) . You can only upload a SNAPSHOT to Maven Central once. We could probably do it using github packages but I haven't had time to investigate this further.

@david-gibbs-ig
Copy link
Author

I checked the settings and actions are activated and allowed. Probably they will only show in PRs once there is an action already defined on the repo.... I just copied your codeql workflow into the repo and now the actions are shown here in the PR.

Re snapshot repo: I briefly investigated this myself in quickfix-j/quickfixj#769 (comment) . You can only upload a SNAPSHOT to Maven Central once. We could probably do it using github packages but I haven't had time to investigate this further.

I replied to quickfix-j/quickfixj#769, I think the practical way to verify this pr , is to build qfj and the examples project locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants