[redhat-3.8] hpa: Do not roll out HPA for unmanage componenets (PROJQUAY-5086) #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only roll out HPA component for managed components
arborite-rh
reviewed
Jan 30, 2024
Comment on lines
+621
to
+627
| var filteredResources []client.Object | ||
| for _, resource := range resources { | ||
| if resource == nil { | ||
| continue | ||
| } | ||
| filteredResources = append(filteredResources, resource) | ||
| } |
There was a problem hiding this comment.
couldn't we do this in one pass?
Suggested change
| var filteredResources []client.Object | |
| for _, resource := range resources { | |
| if resource == nil { | |
| continue | |
| } | |
| filteredResources = append(filteredResources, resource) | |
| } | |
| var filteredResources []client.Object | |
| for _, resource := range resources { | |
| if resource == nil { | |
| continue | |
| } | |
| res, err := v1.EnsureOwnerReference(quay, resource) | |
| if err != nil { | |
| log.Error().Err(err).Msg(...) | |
| continue | |
| } | |
| filteredResources = append(filteredResources, res) | |
| } | |
| return filteredResources, err |
| filteredResources = append(filteredResources, resource) | ||
| } | ||
|
|
||
| for index, resource := range filteredResources { |
There was a problem hiding this comment.
following the suggestion above we could delete the second loop and build our slice in the first loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #885
/assign jonathankingfc