-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quayapp(deploymenttemplate): mounting optional postgres certs (PROJQUAY-2417) #854
Conversation
Hi @michaelalang. Thanks for your PR. I'm waiting for a quay member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8f1fcbf
to
333b913
Compare
- Fix kustomize path for clairpgupgrade when clair is managed/unmanaged
- Remove base from pgupgrade path to ensure that the file location is parsed properly by kustomize package
Bumps [github.com/jackc/pgx/v4](https://github.com/jackc/pgx) from 4.11.0 to 4.18.2. - [Changelog](https://github.com/jackc/pgx/blob/v4.18.2/CHANGELOG.md) - [Commits](jackc/pgx@v4.11.0...v4.18.2) --- updated-dependencies: - dependency-name: github.com/jackc/pgx/v4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
This reverts commit ec6adda.
This reverts commit be722c1.
This reverts commit 29fa2cf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a couple of changes and we're good to go. Can you also rebase? This PR also has to be merged for this to work.
kustomize/base/quay.deployment.yaml
Outdated
optional: true | ||
- secret: | ||
name: postgresql-client-certs | ||
optional: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to use the following indentation where name and optional appear under secret. I wouldn't copy from here since Github formatting seems to be odd.
- name: postgres-certs
projected:
sources:
- secret:
name: postgresql-ca
optional: true
- secret:
name: postgresql-client-certs
optional: true
kustomize/base/quay.deployment.yaml
Outdated
- name: postgres-certs | ||
mountPath: /run/secrets/postgres | ||
- name: postgres-certs-store | ||
mountPath: /.postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be /.postgresql
to match what's defined in quay-entrypoint
kustomize/base/quay.deployment.yaml
Outdated
@@ -129,3 +141,7 @@ spec: | |||
- name: extra-ca-certs | |||
readOnly: true | |||
mountPath: /conf/stack/extra_ca_certs | |||
- name: postgres-certs | |||
mountPath: /run/secrets/postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be /run/secrets/postgresql
to match what's defined in quay-entrypoint
/ok-to-test |
fixed typo in configmap which prevents the deployment to be scheduled