[redhat-3.11] fix: nil check http response when err is not nil (PROJQUAY-6620) #116
Conversation
Topic: projquay-6620 The operator was panicking due to the httpResponse being nil and attempting to return the httpResponse.StatusCode in the response; the response was most likely nil due to a prior error when attempting to marshal json and build the http request itself. This now allows the error to be propagated out to the logs instead of causing the operator to panic fix: addtl nil checking http responses chore: lint_controllers chore: lint quay client Signed-off-by: Ross Bryan <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arborite-rh, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick redhat-3.10 |
|
@dmage: new pull request created: #118 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #111
/assign arborite-rh