Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quay-aio: moved ansible tasks into role (PROJQUAY-1863) #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

quay-aio: moved ansible tasks into role (PROJQUAY-1863) #4

wants to merge 1 commit into from

Conversation

jonathankingfc
Copy link
Collaborator

@jonathankingfc jonathankingfc commented Apr 12, 2021 •
edited
Loading

  • Created role for Quay installer. Tasks to set up systemd services are included.

jeffcpullen
jeffcpullen reviewed Apr 13, 2021
View reviewed changes
roles/quay_installer/tasks/autodetect-image-archive.yaml Outdated
tasks:
- name: Ansible check file exists.
stat:
path: /home/jonathan/image-archive.tar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the /home/jonathan I'm thinking that this path needs to be refactored to be relative for the role.

jeffcpullen
jeffcpullen reviewed Apr 13, 2021
View reviewed changes
roles/quay_installer/tasks/autodetect-image-archive.yaml Outdated
path: /home/jonathan/image-archive.tar
register: p
- name: Image Archive Found. Loading Images.
command: podman load -i /home/jonathan/image-archive.tar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as above. Needs a relative path. Where is this tar file coming from?

@jeffcpullen
Copy link

This needs some refactoring to turn these playbooks into a role. Whats the order they playbooks need to execute in?

@wethinkagile
Copy link
Contributor

wethinkagile commented Apr 13, 2021 •
edited
Loading

@jeffcpullen You can look into my mains file, where the directory orderly gets created and selinuxed. https://github.com/stevek-pro/quay-ansible/blob/quay-3.3.4/roles/r_quay/tasks/main.yml It is then later used in the container call. I plan to PR my entire playbook in the near future.

Program Flow: https://github.com/stevek-pro/quay-ansible/blob/quay-3.3.4/README.md#program-flow

@jonathankingfc jonathankingfc force-pushed the quay_installer_role branch 2 times, most recently from 500ad5e to b50ce36 Compare April 19, 2021 19:55
@thomasmckay
Copy link

@jonathankingfc Can you add a readme or other instructions on how to use?

@jonathankingfc jonathankingfc force-pushed the quay_installer_role branch 20 times, most recently from a37408d to e1f99ec Compare May 14, 2021 03:17
@jonathankingfc jonathankingfc force-pushed the quay_installer_role branch 28 times, most recently from 25662e6 to b57186e Compare June 14, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffcpullen jeffcpullen jeffcpullen left review comments

@aarongreen85 aarongreen85 aarongreen85 left review comments

@thomasmckay thomasmckay Awaiting requested review from thomasmckay

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathankingfc @jeffcpullen @wethinkagile @thomasmckay @aarongreen85