osv: account for event objects that have multiple streams #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
force-pushed
the
osv-account-for-multi-events
branch
from
f1e69c0
to
d9b0770
Compare
It was discovered that some OSV documents can order minor releases in the same affected.ranges object. This meant that only ever counted the last range in a vulnerability. This change gathers range information for the affected product and creates a vulnerability per range. Signed-off-by: crozzy <[email protected]>
crozzy
force-pushed
the
osv-account-for-multi-events
branch
from
d9b0770
to
6fea4d4
Compare
|
Example ranges from an OSV document. "ranges": [
{
"type": "SEMVER",
"events": [
{
"introduced": "0"
},
{
"fixed": "1.21.12"
},
{
"introduced": "1.22.0-0"
},
{
"fixed": "1.22.5"
}
]
}
], |
RTann
reviewed
Oct 18, 2024
| case ev.Introduced == "0": // -Inf | ||
| v.Range.Lower.Kind = `semver` | ||
| case ev.Introduced != "" && seenIntroduced: | ||
| vs = &rangeVer{rng: &claircore.Range{}} |
There was a problem hiding this comment.
if we are assuming it's well-formed (introduced, fixed, introduced, fixed, etc), then I think we can just do vs = &rangeVer{rng: &claircore.Range{}} unconditionally within case ev.Introduced and don't need the if ie == len(r.Events)-1 below. What do you think?
| @@ -554,24 +558,40 @@ func (e *ecs) Insert(ctx context.Context, skipped *stats, name string, a *adviso | |||
| } | |||
| // This does some heavy assumptions about valid inputs. | |||
| ranges := make(url.Values) | |||
There was a problem hiding this comment.
does this need the same kind of treatment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that some OSV documents can order minor releases in the same affected.ranges object. This meant that only ever counted the last range in a vulnerability. This change gathers range information for the affected product and creates a vulnerability per range.