Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel(oval): support unfixed OpenShift 4 vulnerabilities #1163

Closed
wants to merge 1 commit into from

Conversation

RTann
Copy link
Contributor

@RTann RTann commented Nov 28, 2023

The OVAL v2 feeds specifies the next, unreleased version of OpenShift 4 for unfixed OpenShift 4 vulnerabilities. It is meant to indicate each version, y, of OpenShift 4, 4.0 <= y <= 4.x, is affected, where x is the next, unreleased version of OpenShift 4.

ClairCore expects the CPEs to only specify the exact version(s) which is/are affected, as it performs exact matches on the CPEs when matching vulnerabilities. This PR creates clones of the vulnerability for each OpenShift 4 CPE, 4.0 <= y <= 4.x, which is affected by the vulnerability so ClairCore may continue to perform its exact matching on CPEs.

@RTann RTann requested a review from a team as a code owner November 28, 2023 02:17
@RTann RTann requested review from crozzy and removed request for a team November 28, 2023 02:17
@RTann RTann requested a review from hdonnay November 28, 2023 02:20
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (25d5e29) 52.04% compared to head (d57da19) 52.11%.

Files Patch % Lines
rhel/parser.go 62.71% 19 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
+ Coverage   52.04%   52.11%   +0.07%     
==========================================
  Files         220      220              
  Lines       16839    16892      +53     
==========================================
+ Hits         8764     8804      +40     
- Misses       7264     7276      +12     
- Partials      811      812       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RTann
Copy link
Contributor Author

RTann commented Dec 15, 2023

This will be closed in favor of supporting this with VEX files in the future

@RTann RTann closed this Dec 15, 2023
@RTann RTann deleted the ross/unfixed-openshift branch January 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant