httptransport: address review comments

Signed-off-by: Mark Frost <[email protected]>

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "git.alwaysSignOff": true
+}

httptransport/matcher_v1.go

@@ -12,7 +12,7 @@ import (
 
 	"github.com/google/uuid"
 	"github.com/quay/claircore"
-	indexerController "github.com/quay/claircore/indexer/controller"
+	"github.com/quay/claircore/indexer/controller"
 	"github.com/quay/claircore/libvuln/driver"
 	"github.com/quay/zlog"
 	oteltrace "go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace"
@@ -127,7 +127,9 @@ func (h *MatcherV1) vulnerabilityReport(w http.ResponseWriter, r *http.Request)
 		apiError(ctx, w, http.StatusInternalServerError, "experienced a server side error: %v", err)
 	}
 	// now check present and finished only after confirming no err
-	if !ok || indexReport.State != indexerController.IndexFinished.String() {
+	var indexState controller.State
+	indexState.FromString(indexReport.State)
+	if !ok || indexState != controller.IndexFinished {
 		apiError(ctx, w, http.StatusNotFound, "index report for manifest %q not found", manifest.String())
 		return
 	}