fix: update Data SDK err management (#6)

* fix: add req obj validation in GetBidsDelivered method Signed-off-by: Luca Georges Francois <[email protected]> * fix: use req obj validation in GetBidsDelivered method Signed-off-by: Luca Georges Francois <[email protected]> --------- Signed-off-by: Luca Georges Francois <[email protected]>
quartz-technology · Dec 3, 2023 · 0a48ae9 · 0a48ae9
1 parent 494d982
commit 0a48ae9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/sdk/data/v1/data_sdk.go b/sdk/data/v1/data_sdk.go
@@ -24,6 +24,10 @@ func (dataV1 *SDK) GetBidsDelivered(ctx context.Context, params *GetBidsDelivere
 		params = new(GetBidsDeliveredRequest)
 	}
 
+	if err := params.validate(); err != nil {
+		return nil, NewDataSDKError("GetBidsDelivered", err)
+	}
+
 	//nolint:exhaustruct
 	relayReq := &relay.Request{
 		Method: "GET",

diff --git a/sdk/data/v1/req_objects.go b/sdk/data/v1/req_objects.go
@@ -82,6 +82,14 @@ func (r *GetBidsDeliveredRequest) WithOrder(order ResultsOrder) *GetBidsDelivere
 	return r
 }
 
+func (r *GetBidsDeliveredRequest) validate() error {
+	if r.queryParams.Has("slot") && r.queryParams.Has("cursor") {
+		return ErrConflictingParams
+	}
+
+	return nil
+}
+
 type GetBidsReceivedRequest struct {
 	queryParams url.Values
 }
@@ -134,9 +142,5 @@ func (r *GetBidsReceivedRequest) validate() error {
 		return ErrMissingMandatoryParam
 	}
 
-	if r.queryParams.Has("slot") && r.queryParams.Has("cursor") {
-		return ErrConflictingParams
-	}
-
 	return nil
 }