-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.15] Backport Hibernate ORM fixes/workarounds around DB version checks to branch 3.15 #44496
Conversation
And more importantly, that it correctly detects the version configured through persistence.xml.
This allows disabling the check on startup if one knows the database won't be reachable. It also currently defaults to being disabled when a dialect is set explicitly (`quarkus.hibernate-orm.dialect=something`), in order to work around problems we have with correctly detecting the version on some databases that we don't have tests for (unsupported ones).
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
/cc @gsmet (hibernate-orm) |
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
Status for workflow
|
Creating this to backport #43762, as requested by @gsmet because there were conflicts.
This is a backport of:
persistence.xml
and DB versions #43240This one is mostly being backported because otherwise, backporting the next one would result in conflicts.
But I think it makes sense to backport this one too, considering it's only about providing better documentation, testing and error messages for a pre-existing feature.
This is a workaround for Using CockroachDB with Postgres JDBC driver causes failure because of database version #43703 and Microsoft Azure SQL Server Compatibility with Quarkus 3.12.3 #42255, whose complete fixing would require Hibernate ORM 7.