Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.15] Backport Hibernate ORM fixes/workarounds around DB version checks to branch 3.15 #44496

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Nov 14, 2024

Creating this to backport #43762, as requested by @gsmet because there were conflicts.

This is a backport of:

  1. Improve documentation, testing and error messages around persistence.xml and DB versions #43240
    This one is mostly being backported because otherwise, backporting the next one would result in conflicts.
    But I think it makes sense to backport this one too, considering it's only about providing better documentation, testing and error messages for a pre-existing feature.
  2. Add quarkus.hibernate-orm.database.version-check.enabled #43762
    This is a workaround for Using CockroachDB with Postgres JDBC driver causes failure because of database version #43703 and Microsoft Azure SQL Server Compatibility with Quarkus 3.12.3 #42255, whose complete fixing would require Hibernate ORM 7.

And more importantly, that it correctly detects the version configured
through persistence.xml.
This allows disabling the check on startup if one knows the database
won't be reachable.

It also currently defaults to being disabled when a dialect is set
explicitly (`quarkus.hibernate-orm.dialect=something`),
in order to work around problems we have with correctly
detecting the version on some databases that we don't have tests for
(unsupported ones).
@yrodiere yrodiere requested a review from gsmet November 14, 2024 08:52
@quarkus-bot quarkus-bot bot changed the title Backport #43240 / #43762 (Hibernate ORM fixes/workarounds) to branch 3.15 [3.15] Backport #43240 / #43762 (Hibernate ORM fixes/workarounds) to branch 3.15 Nov 14, 2024
Copy link

quarkus-bot bot commented Nov 14, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive labels Nov 14, 2024
Copy link

quarkus-bot bot commented Nov 14, 2024

/cc @gsmet (hibernate-orm)

@yrodiere yrodiere changed the title [3.15] Backport #43240 / #43762 (Hibernate ORM fixes/workarounds) to branch 3.15 [3.15] Backport Hibernate ORM fixes/workarounds around DB version checks to branch 3.15 Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Nov 14, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8f9cd10.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Nov 14, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8f9cd10.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

@gsmet gsmet merged commit 69cdaa2 into quarkusio:3.15 Nov 14, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants