-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Native Image Native Memory Tracking (NMT) option and update docs #44000
Conversation
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It looks like all the GHA tests in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; @zakkak?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
FTR: I considered if it's worth having a check in Quarkus to avoid build failures when using GraalVM < 24.1 (where the nmt
option is not available), but it seems impossible since there is no reliable way to know the GraalVM version before actually running the build (especially in multi-stage builds).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor doc change I thought about on a second pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Robert. It would be great if you could also squash the 2 commits in one (no need to keep the co-authored part).
Status for workflow
|
Status for workflow
|
Thank you @roberttoyonaga. |
Summary
This is a small PR to update the monitoring options to include the new native memory tracking support in Native Image. It's another monitoring option similar to JFR or JMX. I've also done a small corresponding update to the documentation as well.
Users will then be able to include the feature at build time with:
-Dquarkus.native.monitoring=nmt
In addition, I updated the JFR docs with a section on the new functionality in GraalVM for JDK 23.
See here for more info: https://www.graalvm.org/latest/reference-manual/native-image/debugging-and-diagnostics/NMT/