-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto log for dev services in containers #43402
Conversation
This comment has been minimized.
This comment has been minimized.
Really cool! The CI failure seems related, no?
|
Signed-off-by: Phillip Kruger <[email protected]>
042c5f6
to
d29dbf1
Compare
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
|
||
// ... | ||
|
||
private Flow.Publisher<String> createLogPublisher(String containerId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we explan what this is doing? I have 0️⃣ understanding just by eye-balling it for the first time
Status for workflow
|
This PR add a log tab in the Dev UI Footer for every Dev Service, started with a container. It also adds an easy way to add log in the footer tab for any other case, example Dev Services that does not use containers, or just any extension that want to add a log.