Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto log for dev services in containers #43402

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

phillip-kruger
Copy link
Member

This PR add a log tab in the Dev UI Footer for every Dev Service, started with a container. It also adds an easy way to add log in the footer tab for any other case, example Dev Services that does not use containers, or just any extension that want to add a log.
auto_footer_containers

@phillip-kruger phillip-kruger changed the title Auto log for dev services in containers. Auto log for dev services in containers Sep 20, 2024
@quarkusio quarkusio deleted a comment from quarkus-bot bot Sep 20, 2024

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 20, 2024

Really cool!

The CI failure seems related, no?

 Error:  Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.0:java (check-cross-references) on project quarkus-documentation: An exception occurred while executing the Java class. Unable to find cross reference for:
Error:  
Error:  - dev-ui.adoc
Error:      . dev-ui.adoc#add-a-log-file in link <<add-a-log-file,Add a log stream>>
Error:  See https://quarkus.io/guides/doc-reference#cross-references
Error:  -> [Help 1]

Copy link

github-actions bot commented Sep 20, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Sep 20, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit d29dbf1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.


// ...

private Flow.Publisher<String> createLogPublisher(String containerId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we explan what this is doing? I have 0️⃣ understanding just by eye-balling it for the first time

Copy link

quarkus-bot bot commented Sep 20, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d29dbf1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@geoand geoand merged commit 171ca4a into quarkusio:main Sep 23, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants