Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docs reference to old OTel configuration #43362

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Remove docs reference to old OTel configuration #43362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions docs/src/main/asciidoc/opentelemetry-tracing.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,34 +371,7 @@
----
====

[NOTE]
====
Quarkus 3.0 introduced breaking changes on the configuration.

Sampler related property names and values change to comply with the latest Java OpenTelemetry SDK. During a transition period it will be possible to set the new configuration values in the old property because we are mapping `quarkus.opentelemetry.tracer.sampler` -> `quarkus.otel.traces.sampler`.

If the sampler is parent based, there is no need to set, the now dropped property, `quarkus.opentelemetry.tracer.sampler.parent-based`.

The values you need to set on `quarkus.opentelemetry.tracer.sampler` are now:

|===
|Old Sampler config value |New Sampler config value|New Sampler config value (Parent based)

|`on`
|`always_on`
|`parentbased_always_on`

|`off`
|`always_off`
|`parentbased_always_off`

|`ratio`
|`traceidratio`
|`parentbased_traceidratio`
|===
====

If you need to use a custom sampler there are now 2 different ways:

Check warning on line 374 in docs/src/main/asciidoc/opentelemetry-tracing.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Fluff] Depending on the context, consider using 'Rewrite the sentence, or use 'must', instead of' rather than 'need to'.

Raw Output:
{"message": "[Quarkus.Fluff] Depending on the context, consider using 'Rewrite the sentence, or use 'must', instead of' rather than 'need to'.", "location": {"path": "docs/src/main/asciidoc/opentelemetry-tracing.adoc", "range": {"start": {"line": 374, "column": 8}}}, "severity": "INFO"}

Check warning on line 374 in docs/src/main/asciidoc/opentelemetry-tracing.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Headings] Use sentence-style capitalization in 'Sampler CDI Producer'.

Raw Output:
{"message": "[Quarkus.Headings] Use sentence-style capitalization in 'Sampler CDI Producer'.", "location": {"path": "docs/src/main/asciidoc/opentelemetry-tracing.adoc", "range": {"start": {"line": 374, "column": 26}}}, "severity": "INFO"}

==== Sampler CDI Producer

Expand Down