Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: Support using PKCS12 keystores for creating signed JWT tokens #43304

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 15, 2024

This differs from #43176 description slightly in a fact that we assume JKS if the keystore file extension is not recognized. But that is only because I want to keep current behavior and use one method inside OIDC. IMHO we need to be consistent inside OIDC.

Also, this makes this PR backwards compatible.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/oidc labels Sep 15, 2024
Copy link

github-actions bot commented Sep 15, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Sep 15, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit bf81d72.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Sep 15, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bf81d72.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik

@sberyozkin
Copy link
Member

Usually it is a p12 extension, but having an expanded name to test is good

@sberyozkin sberyozkin merged commit 586592e into quarkusio:main Sep 15, 2024
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 15, 2024
@michalvavrik michalvavrik deleted the feauture/oidc-support-jwt-cred-stored-in-p12 branch September 15, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC can only use JKS keystores for creating signed JWT tokens
2 participants