-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Keycloak Admin Client with TLS registry #43303
Integrate Keycloak Admin Client with TLS registry #43303
Conversation
michalvavrik
commented
Sep 15, 2024
- Closes: Enhance keycloak-admin-client extension to support TLS trust and key stores #37243
1c0ca5f
to
e5d8e34
Compare
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
e5d8e34
to
5b5a4d1
Compare
Thanks @sberyozkin; cc @geoand in case you wanna check, I configure REST client with TLS registry just as you did in #41153 so I expect it's alright |
This comment has been minimized.
This comment has been minimized.
sorry @sberyozkin , I didn't know there are native tests so I didn't run them. it seems that Keycloak's |
This comment has been minimized.
This comment has been minimized.
5b5a4d1
to
c4d9750
Compare
c4d9750
to
c973daf
Compare
c973daf
to
4115e48
Compare
Status for workflow
|
Status for workflow
|
Changes inside Keycloak Admin Resteasy Client are due to the fact that I changed time when we set Keycloak Rest client provider (from static to runtime). This meant that during static init when native image is build this was executed: https://github.com/keycloak/keycloak/blob/75973157aa10bdbcb04d82af490a495dbb0b35a7/integration/admin-client/src/main/java/org/keycloak/admin/client/Keycloak.java#L46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michalvavrik