Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update websockets-next-reference.adoc with Tenants #43144

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Update websockets-next-reference.adoc with Tenants #43144

merged 1 commit into from
Sep 12, 2024

Conversation

Paul6552
Copy link
Contributor

@Paul6552 Paul6552 commented Sep 9, 2024

Describe how users can access headers in websockets-next and use it in CustomTenantResolver with normal Rest-Calls.

@Paul6552 Paul6552 mentioned this pull request Sep 9, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand requested a review from mkouba September 10, 2024 05:38
cescoffier
cescoffier requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks mostly good. Please look at the various suggestions from @mkouba and myself.

docs/src/main/asciidoc/websockets-next-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/websockets-next-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/websockets-next-reference.adoc Outdated Show resolved Hide resolved
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
cescoffier
cescoffier approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you squash your commits into a single one?

@Paul6552
Copy link
Contributor Author

@cescoffier
I am really sorry. I have no idea how to do this. These doc changes where made over the web via github website. I found some command lines therefore I tried to clone the project again into my IDE, but couldn`t find my branch to squash my commits. I hope you can do it anyhow.

@cescoffier
Copy link
Member

No worries, I will do that.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@Paul6552 @cescoffier
Update websockets-next-reference.adoc with Tenants
2794090 
Describe how users can access headers in websockets-next and use it in CustomTenantResolver with normal Rest-Calls.
@cescoffier
Copy link
Member

@Paul6552 I just did it - waiting for CI and merging!

Thanks for your contribution!

@cescoffier cescoffier added triage/waiting-for-ci Ready to merge when CI successfully finishes area/websockets labels Sep 12, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 2794090.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier merged commit ee86d36 into quarkusio:main Sep 12, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 12, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 12, 2024
@cescoffier
Copy link
Member

Merged! Thanks @Paul6552 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba left review comments

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/documentation area/websockets
Projects
None yet
Milestone
3.16.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@Paul6552 @cescoffier @mkouba