Update to latest Snowdrop Buildpack Platform Impl #41936

BarDweller · 2024-07-16T17:59:24Z

Significant update to the buildpack platform implementation used by the buildpack container image extension.

Updates from snowdrop lib 0.0.6 to 0.0.10 bringing support for builder images using image extensions, and updating the default builder to be the paketo ubi builder image. Also contains updates for podman compatibility, image pull retry, and various other minor fixes.

quarkus-bot · 2024-07-16T17:59:27Z

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

title should not end up with dot

_{This message is automatically generated by a bot.}

gsmet

Thanks! I added a small minor comment, either for this time or next depending on how the CI goes.

gsmet · 2024-07-17T07:15:30Z

...eployment/src/main/java/io/quarkus/container/image/buildpack/deployment/BuildpackConfig.java

+    @ConfigItem(defaultValue = "paketocommunity/builder-ubi-base")
    public Optional<String> jvmBuilderImage;


Given you provided a default value, you should drop the Optional.

Same for the one just below.

It's not mandatory so I suppose we can live with it if you don't have to push other changes but if CI doesn't pass and you do, please drop the Optional. Thanks!

geoand · 2024-07-19T09:22:35Z

What's the status of this?

BarDweller · 2024-07-19T11:20:40Z

What's the status of this?

I'm removing the optional, and also performing a few more tests locally with native builds, that have thrown a curveball.. I'll add the PR for the Optional & removal of the native builder default.. There will probably be a new PR for the native changes

BarDweller · 2024-07-26T20:50:20Z

Summary of findings from post-review comments...

builder default removed for native build, the paketo ubi builder does not do native builds, there is currently no available builder to configure for quarkus native builds.
testing performed locally to validate that native builds were possible for quarkus using a custom builder image derived from the quarkus mandrel container.
testing uncovered issue in snowdrop lib related to builder images with unexpected entrypoint configurations. Snowdrop lib fixed, and re-released as 0.0.11
exposed a few more config options from the snowdrop lib via quarkus that were helpful during native testing.

Quarkus native builder image can be constructed relatively simply, although it ends up as a builder per java version, need to look into if the github project that publishes the quarkus mandrel images could also do buildpack builder images..

Quarkus buildpack also needs an update, as it's using deprecated property names.. raised paketo-buildpacks/quarkus#83 and will help get that updated.

geoand

LGTM

geoand · 2024-07-29T13:26:51Z

@iocanel mind taking a look as well?

iocanel

LGTM

michalvavrik · 2024-07-29T13:38:27Z

...eployment/src/main/java/io/quarkus/container/image/buildpack/deployment/BuildpackConfig.java


    /**
-     * The buildpacks builder image to use when building the project in jvm mode.
+     * The buildpacks builder image to use when building the project in native mode.pu


typo mode.pu ?

geoand · 2024-07-30T06:48:51Z

Please squash the commits

iocanel · 2024-07-30T07:40:15Z

...oyment/src/main/java/io/quarkus/container/image/buildpack/deployment/BuildpackProcessor.java

                        if (buildpackConfig.dockerHost.isPresent()) {
                            log.info("Using DockerHost of " + buildpackConfig.dockerHost.get());
-                            b.withDockerHost(buildpackConfig.dockerHost.get());
+                            b.editDockerConfig().withDockerHost(buildpackConfig.dockerHost.get());


Suggested change

b.editDockerConfig().withDockerHost(buildpackConfig.dockerHost.get());

b.editDockerConfig().withDockerHost(buildpackConfig.dockerHost.get()).endDockerConfig();

iocanel · 2024-07-30T07:40:41Z

...oyment/src/main/java/io/quarkus/container/image/buildpack/deployment/BuildpackProcessor.java

-                    }).build();
+                        if (buildpackConfig.trustBuilderImage.isPresent()) {
+                            log.info("Setting trusted image to " + buildpackConfig.trustBuilderImage.get());
+                            b.editPlatformConfig().withTrustBuilder(buildpackConfig.trustBuilderImage.get());


Suggested change

b.editPlatformConfig().withTrustBuilder(buildpackConfig.trustBuilderImage.get());

b.editPlatformConfig().withTrustBuilder(buildpackConfig.trustBuilderImage.get()).endPlatformConfig();

iocanel

There is a minor issue with the the use of editXXX as its seems that the endXXX is missing. The intention is that the actual edited value is set when you actually call the endXXX method.

For example:

   ObjectMetaBuilder builder;

    public N endMetadata() {
      return (N) MyFluent.this.withMetadata(builder.build());
    }

BarDweller · 2024-07-30T18:57:21Z

Updating to add endXXXConfig and rerunning local tests.. will squash merge when done

BarDweller · 2024-08-19T13:57:39Z

Updated, found issue with snowdrop library not honoring docker pull timeout/timeout increase amounts, fixed library, updated quarkus usage.. tested as functional.

cmoulliard · 2024-09-13T13:48:10Z

What is the status ? @BarDweller

BarDweller · 2024-09-13T13:51:54Z

Just needs a small git tidy up so it can be re-reviewed/merged.. (merge commit snuck in when I updated to latest branch.. need to rebase & force push to sort it out.. will be done by eod)

github-actions · 2024-09-19T15:28:07Z

🎊 PR Preview bddf9a3 has been successfully built and deployed to https://quarkus-pr-main-41936-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

quarkus-bot · 2024-09-19T19:11:19Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit e83abe0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2024-09-19T22:16:00Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit e83abe0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

iocanel

LGTM

quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jul 16, 2024

BarDweller changed the title ~~Update to latest Snowdrop Buildpack Platform Impl.~~ Update to latest Snowdrop Buildpack Platform Impl Jul 16, 2024

gastaldi requested a review from geoand July 16, 2024 23:08

geoand approved these changes Jul 17, 2024

View reviewed changes

geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 17, 2024

gsmet reviewed Jul 17, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

geoand removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 18, 2024

geoand approved these changes Jul 29, 2024

View reviewed changes

geoand requested a review from iocanel July 29, 2024 13:26

iocanel approved these changes Jul 29, 2024

View reviewed changes

michalvavrik reviewed Jul 29, 2024

View reviewed changes

geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 29, 2024

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Jul 29, 2024

iocanel reviewed Jul 30, 2024

View reviewed changes

iocanel self-requested a review July 30, 2024 07:43

iocanel requested changes Jul 30, 2024

View reviewed changes

BarDweller force-pushed the buildpack-update branch 2 times, most recently from 3ee34fa to 846d887 Compare August 19, 2024 13:55

BarDweller force-pushed the buildpack-update branch 2 times, most recently from c3d52ab to c18c4b2 Compare September 19, 2024 14:51

quarkus-bot bot added the area/documentation label Sep 19, 2024

Update to latest Snowdrop Buildpack platform impl

e83abe0

BarDweller force-pushed the buildpack-update branch from c18c4b2 to e83abe0 Compare September 19, 2024 15:02

This comment has been minimized.

Sign in to view

geoand requested a review from iocanel September 19, 2024 18:33

iocanel approved these changes Sep 20, 2024

View reviewed changes

geoand merged commit c99a22d into quarkusio:main Sep 20, 2024
54 checks passed

quarkus-bot bot added kind/bugfix kind/enhancement New feature or request labels Sep 20, 2024

quarkus-bot bot added this to the 3.16 - main milestone Sep 20, 2024

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to latest Snowdrop Buildpack Platform Impl #41936

Update to latest Snowdrop Buildpack Platform Impl #41936

BarDweller commented Jul 16, 2024 •

edited by geoand

Loading

quarkus-bot bot commented Jul 16, 2024

gsmet left a comment

gsmet Jul 17, 2024

This comment has been minimized.

geoand commented Jul 19, 2024

BarDweller commented Jul 19, 2024

BarDweller commented Jul 26, 2024

geoand left a comment

geoand commented Jul 29, 2024

iocanel left a comment

michalvavrik Jul 29, 2024

This comment has been minimized.

geoand commented Jul 30, 2024

iocanel Jul 30, 2024

iocanel Jul 30, 2024

iocanel left a comment

BarDweller commented Jul 30, 2024

BarDweller commented Aug 19, 2024

cmoulliard commented Sep 13, 2024

BarDweller commented Sep 13, 2024

github-actions bot commented Sep 19, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

quarkus-bot bot commented Sep 19, 2024

quarkus-bot bot commented Sep 19, 2024 •

edited by github-actions bot

Loading

iocanel left a comment

		@ConfigItem(defaultValue = "paketocommunity/builder-ubi-base")
		public Optional<String> jvmBuilderImage;

	b.editDockerConfig().withDockerHost(buildpackConfig.dockerHost.get());
	b.editDockerConfig().withDockerHost(buildpackConfig.dockerHost.get()).endDockerConfig();

	b.editPlatformConfig().withTrustBuilder(buildpackConfig.trustBuilderImage.get());
	b.editPlatformConfig().withTrustBuilder(buildpackConfig.trustBuilderImage.get()).endPlatformConfig();

Update to latest Snowdrop Buildpack Platform Impl #41936

Update to latest Snowdrop Buildpack Platform Impl #41936

Conversation

BarDweller commented Jul 16, 2024 • edited by geoand Loading

quarkus-bot bot commented Jul 16, 2024

gsmet left a comment

Choose a reason for hiding this comment

gsmet Jul 17, 2024

Choose a reason for hiding this comment

This comment has been minimized.

geoand commented Jul 19, 2024

BarDweller commented Jul 19, 2024

BarDweller commented Jul 26, 2024

geoand left a comment

Choose a reason for hiding this comment

geoand commented Jul 29, 2024

iocanel left a comment

Choose a reason for hiding this comment

michalvavrik Jul 29, 2024

Choose a reason for hiding this comment

This comment has been minimized.

geoand commented Jul 30, 2024

iocanel Jul 30, 2024

Choose a reason for hiding this comment

iocanel Jul 30, 2024

Choose a reason for hiding this comment

iocanel left a comment

Choose a reason for hiding this comment

BarDweller commented Jul 30, 2024

BarDweller commented Aug 19, 2024

cmoulliard commented Sep 13, 2024

BarDweller commented Sep 13, 2024

github-actions bot commented Sep 19, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

quarkus-bot bot commented Sep 19, 2024

Status for workflow Quarkus Documentation CI

quarkus-bot bot commented Sep 19, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

iocanel left a comment

Choose a reason for hiding this comment

BarDweller commented Jul 16, 2024 •

edited by geoand

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Sep 19, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`