TemporalInstance Beans #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Sep 2, 2024
|
|
||
| producer.produce( | ||
| SyntheticBeanBuildItem.configure( | ||
| ParameterizedType.create(TemporalInstance.class, ClassType.create(workflowBuildItem.workflow)) |
There was a problem hiding this comment.
You need to add the parameterized type to the set of bean types, e.g. with BeanConfiguratorBase#addType(Type). The configure() method only accepts the implementation class, i.e. something like this should work:
SyntheticBeanBuildItem.configure(TemporalInstance.class)
.addType(ParameterizedType.create(TemporalInstance.class, ClassType.create(workflowBuildItem.workflow))
.scope(...)There was a problem hiding this comment.
indeed, it's working now, thanks a lot !
rmanibus
force-pushed
the
temporal_instance
branch
2 times, most recently
from
9eb7a33
to
9ba89b8
Compare
rmanibus
force-pushed
the
temporal_instance
branch
from
9ba89b8
to
3fe8493
Compare
melloware
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.