PrimeFaces 14.0.0-RC3

quarkiverse · Apr 16, 2024 · 2abf5dd · 2abf5dd
1 parent f778096
commit 2abf5dd
Show file tree

Hide file tree

Showing 17 changed files with 53 additions and 36 deletions.
diff --git a/README.md b/README.md
@@ -58,8 +58,9 @@ For example:
 
 | Version | Explanation |
 | --- | --- |
-| ![2.x](https://img.shields.io/maven-central/v/io.quarkiverse.primefaces/quarkus-primefaces?versionPrefix=2.&color=cyan) | Quarkus 2 (EE8), PrimeFaces 12 |
-| ![3.x](https://img.shields.io/maven-central/v/io.quarkiverse.primefaces/quarkus-primefaces?versionPrefix=3.&color=cyan) | Quarkus 3 (EEE10), PrimeFaces 13 |
+| ![2.12.x](https://img.shields.io/maven-central/v/io.quarkiverse.primefaces/quarkus-primefaces?versionPrefix=2.&color=cyan) | Quarkus 2 (EE8), PrimeFaces 12 |
+| ![3.13.x](https://img.shields.io/maven-central/v/io.quarkiverse.primefaces/quarkus-primefaces?versionPrefix=3.13&color=cyan) | Quarkus 3 (EEE10), PrimeFaces 13 |
+| ![3.14.x](https://img.shields.io/maven-central/v/io.quarkiverse.primefaces/quarkus-primefaces?versionPrefix=3.14&color=cyan) | Quarkus 3 (EEE10), PrimeFaces 14 |
 
 > [!IMPORTANT]  
 > FeedReader component is not supported in GraalVM Native Image mode due to complexities with their third party library Rome.

diff --git a/docs/pom.xml b/docs/pom.xml
@@ -53,7 +53,8 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-resources-plugin</artifactId>
                 <executions>
                     <execution>

diff --git a/pom.xml b/pom.xml
@@ -27,8 +27,8 @@
     <quarkus.version>3.8.3</quarkus.version>
     <quarkus-poi.version>2.0.5</quarkus-poi.version>
     <quarkus-itext.version>3.0.4</quarkus-itext.version>
-    <primefaces.version>13.0.8</primefaces.version>
-    <primefaces-extensions.version>13.0.8</primefaces-extensions.version>
+    <primefaces.version>14.0.0-RC3</primefaces.version>
+    <primefaces-extensions.version>14.0.0-RC3</primefaces-extensions.version>
     <myfaces.version>4.0.2</myfaces.version>
     <compiler-plugin.version>3.13.0</compiler-plugin.version>
     <maven.compiler.release>17</maven.compiler.release>
@@ -97,6 +97,17 @@
       </dependency>
     </dependencies>
   </dependencyManagement>
+  <repositories>
+    <repository>
+      <id>apache.snapshots</id>
+      <name>Apache Development Snapshot Repository</name>
+      <url>https://repository.apache.org/content/repositories/snapshots/</url>
+      <releases>
+        <enabled>false</enabled>
+      </releases>
+      <snapshots />
+    </repository>
+  </repositories>
   <build>
     <pluginManagement>
       <plugins>
@@ -117,15 +128,4 @@
       </plugins>
     </pluginManagement>
   </build>
-  <repositories>
-    <repository>
-      <id>apache.snapshots</id>
-      <name>Apache Development Snapshot Repository</name>
-      <url>https://repository.apache.org/content/repositories/snapshots/</url>
-      <releases>
-        <enabled>false</enabled>
-      </releases>
-      <snapshots />
-    </repository>
-  </repositories>
 </project>
diff --git a/quarkus-primefaces-extensions/deployment/pom.xml b/quarkus-primefaces-extensions/deployment/pom.xml
@@ -39,7 +39,8 @@
     </dependencies>
     <build>
         <plugins>
-            <plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
                     <annotationProcessorPaths>

diff --git a/...uarkiverse/primefaces/extensions/deployment/devui/PrimeFacesExtensionsDevUIProcessor.java b/...uarkiverse/primefaces/extensions/deployment/devui/PrimeFacesExtensionsDevUIProcessor.java
@@ -6,6 +6,7 @@
 import io.quarkus.deployment.annotations.BuildProducer;
 import io.quarkus.deployment.annotations.BuildStep;
 import io.quarkus.devui.spi.page.CardPageBuildItem;
+import io.quarkus.devui.spi.page.ExternalPageBuilder;
 import io.quarkus.devui.spi.page.Page;
 import io.quarkus.devui.spi.page.PageBuilder;
 
@@ -18,7 +19,7 @@ public class PrimeFacesExtensionsDevUIProcessor {
     void createCard(BuildProducer<CardPageBuildItem> cardPageBuildItemBuildProducer) {
         final CardPageBuildItem card = new CardPageBuildItem();
 
-        final PageBuilder versionPage = Page.externalPageBuilder("Version")
+        final PageBuilder<ExternalPageBuilder> versionPage = Page.externalPageBuilder("Version")
                 .icon("font-awesome-solid:book")
                 .url("https://primefaces-extensions.github.io/")
                 .doNotEmbed()

diff --git a/quarkus-primefaces-extensions/integration-tests/pom.xml b/quarkus-primefaces-extensions/integration-tests/pom.xml
@@ -55,7 +55,8 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-failsafe-plugin</artifactId>
                 <executions>
                     <execution>
@@ -87,7 +88,8 @@
             </activation>
             <build>
                 <plugins>
-                    <plugin>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-surefire-plugin</artifactId>
                         <configuration>
                             <skipTests>${native.surefire.skip}</skipTests>

diff --git a/...ion-tests/src/main/java/io/quarkiverse/primefaces/extensions/it/InputPhoneController.java b/...ion-tests/src/main/java/io/quarkiverse/primefaces/extensions/it/InputPhoneController.java
@@ -16,6 +16,7 @@
 */
 package io.quarkiverse.primefaces.extensions.it;
 
+import java.io.Serial;
 import java.io.Serializable;
 import java.util.HashMap;
 import java.util.Map;
@@ -38,6 +39,7 @@
 @ViewScoped
 public class InputPhoneController implements Serializable {
 
+    @Serial
     private static final long serialVersionUID = 1L;
     private String phoneNumber;
     private Map<String, String> localizedCountries;
@@ -67,4 +69,4 @@ public void submit() {
         log.info(submitted);
     }
 
-}
+}
diff --git a/...tion-tests/src/main/java/io/quarkiverse/primefaces/extensions/it/LocalizedController.java b/...tion-tests/src/main/java/io/quarkiverse/primefaces/extensions/it/LocalizedController.java
@@ -16,6 +16,7 @@
 */
 package io.quarkiverse.primefaces.extensions.it;
 
+import java.io.Serial;
 import java.io.Serializable;
 
 import jakarta.annotation.PostConstruct;
@@ -31,6 +32,7 @@
 @ViewScoped
 public class LocalizedController implements Serializable {
 
+    @Serial
     private static final long serialVersionUID = 1L;
     private String test;
 
@@ -39,4 +41,4 @@ protected void init() {
         log.info("LocalizedController postConstruct()");
         test = "Localized Test";
     }
-}
+}
diff --git a/quarkus-primefaces-extensions/runtime/pom.xml b/quarkus-primefaces-extensions/runtime/pom.xml
@@ -86,7 +86,8 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
                     <annotationProcessorPaths>

diff --git a/quarkus-primefaces/deployment/pom.xml b/quarkus-primefaces/deployment/pom.xml
@@ -44,7 +44,8 @@
     </dependencies>
     <build>
         <plugins>
-            <plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
                     <annotationProcessorPaths>

diff --git a/...es/deployment/src/main/java/io/quarkiverse/primefaces/deployment/PrimefacesProcessor.java b/...es/deployment/src/main/java/io/quarkiverse/primefaces/deployment/PrimefacesProcessor.java
@@ -104,7 +104,6 @@ void registerForReflection(PrimeFacesRecorder recorder, BuildProducer<Reflective
         // All utilities
         final List<String> classNames = new ArrayList<>(List.of(
                 org.primefaces.expression.SearchExpressionUtils.class.getName(),
-                org.primefaces.expression.SearchExpressionFacade.class.getName(),
                 org.primefaces.clientwindow.PrimeClientWindowUtils.class.getName(),
                 org.primefaces.renderkit.RendererUtils.class.getName(),
                 org.primefaces.seo.JsonLD.class.getName(),

diff --git a/...nt/src/main/java/io/quarkiverse/primefaces/deployment/devui/PrimeFacesDevUIProcessor.java b/...nt/src/main/java/io/quarkiverse/primefaces/deployment/devui/PrimeFacesDevUIProcessor.java
@@ -6,6 +6,7 @@
 import io.quarkus.deployment.annotations.BuildProducer;
 import io.quarkus.deployment.annotations.BuildStep;
 import io.quarkus.devui.spi.page.CardPageBuildItem;
+import io.quarkus.devui.spi.page.ExternalPageBuilder;
 import io.quarkus.devui.spi.page.Page;
 import io.quarkus.devui.spi.page.PageBuilder;
 
@@ -18,7 +19,7 @@ public class PrimeFacesDevUIProcessor {
     void createCard(BuildProducer<CardPageBuildItem> cardPageBuildItemBuildProducer) {
         final CardPageBuildItem card = new CardPageBuildItem();
 
-        final PageBuilder versionPage = Page.externalPageBuilder("Version")
+        final PageBuilder<ExternalPageBuilder> versionPage = Page.externalPageBuilder("Version")
                 .icon("font-awesome-solid:book")
                 .url("https://www.primefaces.org/showcase/")
                 .doNotEmbed()

diff --git a/quarkus-primefaces/integration-tests/pom.xml b/quarkus-primefaces/integration-tests/pom.xml
@@ -56,6 +56,7 @@
         </executions>
       </plugin>
       <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-failsafe-plugin</artifactId>
         <executions>
           <execution>
@@ -88,6 +89,7 @@
       <build>
         <plugins>
           <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-surefire-plugin</artifactId>
             <configuration>
               <skipTests>${native.surefire.skip}</skipTests>

diff --git a/...s-primefaces/integration-tests/src/main/java/io/quarkiverse/primefaces/it/CarService.java b/...s-primefaces/integration-tests/src/main/java/io/quarkiverse/primefaces/it/CarService.java
@@ -61,7 +61,7 @@ public class CarService {
     }
 
     public List<Car> createCars(int size) {
-        List<Car> list = new ArrayList<Car>();
+        List<Car> list = new ArrayList<>();
         for (int i = 0; i < size; i++) {
             list.add(new Car(getRandomId(), getRandomBrand(), getRandomYear(),
                     getRandomColor(), getRandomPrice(), getRandomSoldState()));
@@ -101,4 +101,4 @@ public List<String> getColors() {
     public List<String> getBrands() {
         return Arrays.asList(BRANDS);
     }
-}
+}
diff --git a/...efaces/integration-tests/src/main/java/io/quarkiverse/primefaces/it/LazyCarDataModel.java b/...efaces/integration-tests/src/main/java/io/quarkiverse/primefaces/it/LazyCarDataModel.java
@@ -19,7 +19,6 @@
 package io.quarkiverse.primefaces.it;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
@@ -57,7 +56,7 @@ public String getRowKey(Car car) {
 
     @Override
     public List<Car> load(int first, int pageSize, Map<String, SortMeta> sortMeta, Map<String, FilterMeta> filterMeta) {
-        List<Car> data = new ArrayList<Car>();
+        List<Car> data = new ArrayList<>();
 
         //filter
         for (Car car : datasource) {
@@ -90,7 +89,7 @@ public List<Car> load(int first, int pageSize, Map<String, SortMeta> sortMeta, M
         //sort
         if (sortMeta != null) {
             for (SortMeta current : sortMeta.values()) {
-                Collections.sort(data, new LazySorter(current.getField(), current.getOrder()));
+                data.sort(new LazySorter(current.getField(), current.getOrder()));
             }
         }
 
@@ -114,4 +113,4 @@ public List<Car> load(int first, int pageSize, Map<String, SortMeta> sortMeta, M
     public int count(Map<String, FilterMeta> map) {
         return 0;
     }
-}
+}
diff --git a/.../integration-tests/src/test/java/io/quarkiverse/primefaces/it/PrimeFacesResourceTest.java b/.../integration-tests/src/test/java/io/quarkiverse/primefaces/it/PrimeFacesResourceTest.java
@@ -4,6 +4,7 @@
 
 import java.net.URL;
 
+import lombok.extern.jbosslog.JBossLog;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
@@ -17,6 +18,7 @@
 import io.quarkus.test.common.http.TestHTTPResource;
 import io.quarkus.test.junit.QuarkusTest;
 
+@JBossLog
 @QuarkusTest
 @WithPlaywright
 public class PrimeFacesResourceTest {
@@ -31,9 +33,10 @@ public class PrimeFacesResourceTest {
     URL accessibility;
 
     @Test
-    public void shouldOpenIndexPage() throws Exception {
+    public void shouldOpenIndexPage() {
         final Page page = context.newPage();
         Response response = page.navigate(index.toString());
+        log.infof("Response: %s", response.text());
         Assertions.assertEquals("OK", response.statusText());
 
         page.waitForLoadState();
@@ -49,7 +52,7 @@ public void shouldOpenIndexPage() throws Exception {
     }
 
     @Test
-    public void shouldAllowTemplate() throws Exception {
+    public void shouldAllowTemplate() {
         final Page page = context.newPage();
         Response response = page.navigate(accessibility.toString());
         Assertions.assertEquals("OK", response.statusText());
@@ -58,4 +61,4 @@ public void shouldAllowTemplate() throws Exception {
         String title = page.title();
         Assertions.assertEquals("Accessibility", title);
     }
-}
+}
diff --git a/quarkus-primefaces/runtime/pom.xml b/quarkus-primefaces/runtime/pom.xml
@@ -74,7 +74,8 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
                     <annotationProcessorPaths>