Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AVX- and SSE-using targets as incompatible with non-x86 platforms. #563

Closed
wants to merge 1 commit into from

Conversation

lexi-nadia
Copy link

No description provided.

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Sep 23, 2022
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Sep 23, 2022
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I've triggered the Kokoro build to test the C++ build across Linux/Mac/Windows - if there are any odd edge cases that should surface them for us.

@95-martin-orion
Copy link
Collaborator

@lexi-nadia the Kokoro logs should be visible from the details link - let me know if you don't have access.

From those logs:

//lib:statespace_avx: no such attribute 'target_compatible_with' in 'cc_library' rule
{ ...similar logs for other rules... }

@95-martin-orion
Copy link
Collaborator

Summary of offline discussion: target_compatible_with was not added until bazel v4.0. While the qsim bazel version could plausibly advance (although see #526 for issues around that), it cannot advance past the bazel version used in Tensorflow Quantum, which is 3.7.2.

Instead, these changes will be applied to the pipeline used to construct the Google-internal mirror of qsim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants