Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and enforce explicit re-export for cirq modules #6722

Merged
merged 25 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b726cff
Fixed issue #6717
ashiq-firoz Sep 8, 2024
ce9dd20
Fixed issue #6717
ashiq-firoz Sep 8, 2024
3a93702
Update __init__.py
ashiq-firoz Sep 8, 2024
ffa54ff
Fixed issue #6717
ashiq-firoz Sep 8, 2024
9161701
Fixed issue #6717
ashiq-firoz Sep 8, 2024
acfc2d1
Fixed issue #6717
ashiq-firoz Sep 8, 2024
eb26672
Fixed issue #6717
ashiq-firoz Sep 8, 2024
a72940c
Fixed issue #6717
ashiq-firoz Sep 8, 2024
c3613dc
Fixed issue #6717
ashiq-firoz Sep 8, 2024
d653c80
Fixed issue #6717
ashiq-firoz Sep 8, 2024
1328157
Fixed issue #6717
ashiq-firoz Sep 8, 2024
808a6db
Made changes as mentioned
ashiq-firoz Sep 10, 2024
ed39e49
Apply the no_implicit_reexport mypy rule for cirq modules only
pavoljuhas Sep 11, 2024
fe2b244
Import ModuleType directly from types
pavoljuhas Sep 11, 2024
34c9279
Clean obsolete workaround for a dead mypy bug
pavoljuhas Sep 11, 2024
445084a
Fix complaint about reexport of InsertStrategy from cirq.circuits.cir…
pavoljuhas Sep 11, 2024
827f34b
Fix complaint about reexport of PauliString
pavoljuhas Sep 11, 2024
fce7ca2
Fix complaint about reexport of SwapPowGate
pavoljuhas Sep 11, 2024
aeb546d
Format changed files
pavoljuhas Sep 11, 2024
c0db8ff
Do not re-export _register_resolver and _class_resolver_dictionary
pavoljuhas Sep 11, 2024
a7c21e1
Do not reexport `_compat` it is used internally in initialization
pavoljuhas Sep 11, 2024
61707d0
Revert modules that define exports with their `__all__` list
pavoljuhas Sep 11, 2024
d615c60
Clean spurious re-export
pavoljuhas Sep 11, 2024
93320e3
Do not re-export submodules already in the namespace
pavoljuhas Sep 11, 2024
7f98fd3
Address pylint on line-too-long
pavoljuhas Sep 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cirq-aqt/cirq_aqt/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@

"""Types and methods related to the AQT ion trap device"""

from cirq_aqt._version import __version__

from cirq_aqt.aqt_sampler import AQTSampler, AQTSamplerLocalSimulator
from cirq_aqt.aqt_device import AQTSimulator
from cirq_aqt._version import __version__ as __version__
from cirq_aqt.aqt_sampler import (
AQTSampler as AQTSampler,
AQTSamplerLocalSimulator as AQTSamplerLocalSimulator,
)
from cirq_aqt.aqt_device import AQTSimulator as AQTSimulator
2 changes: 1 addition & 1 deletion cirq-aqt/cirq_aqt/json_test_data/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
# cirq/protocols/json_serialization_test.py which checks for coverage of
# public classes and tests the correctness of repr and json results

from cirq_aqt.json_test_data.spec import TestSpec
from cirq_aqt.json_test_data.spec import TestSpec as TestSpec
Loading