-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement and enforce explicit re-export for cirq modules #6722
Merged
Merged
Changes from 11 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
b726cff
Fixed issue #6717
ashiq-firoz ce9dd20
Fixed issue #6717
ashiq-firoz 3a93702
Update __init__.py
ashiq-firoz ffa54ff
Fixed issue #6717
ashiq-firoz 9161701
Fixed issue #6717
ashiq-firoz acfc2d1
Fixed issue #6717
ashiq-firoz eb26672
Fixed issue #6717
ashiq-firoz a72940c
Fixed issue #6717
ashiq-firoz c3613dc
Fixed issue #6717
ashiq-firoz d653c80
Fixed issue #6717
ashiq-firoz 1328157
Fixed issue #6717
ashiq-firoz 808a6db
Made changes as mentioned
ashiq-firoz ed39e49
Apply the no_implicit_reexport mypy rule for cirq modules only
pavoljuhas fe2b244
Import ModuleType directly from types
pavoljuhas 34c9279
Clean obsolete workaround for a dead mypy bug
pavoljuhas 445084a
Fix complaint about reexport of InsertStrategy from cirq.circuits.cir…
pavoljuhas 827f34b
Fix complaint about reexport of PauliString
pavoljuhas fce7ca2
Fix complaint about reexport of SwapPowGate
pavoljuhas aeb546d
Format changed files
pavoljuhas c0db8ff
Do not re-export _register_resolver and _class_resolver_dictionary
pavoljuhas a7c21e1
Do not reexport `_compat` it is used internally in initialization
pavoljuhas 61707d0
Revert modules that define exports with their `__all__` list
pavoljuhas d615c60
Clean spurious re-export
pavoljuhas 93320e3
Do not re-export submodules already in the namespace
pavoljuhas 7f98fd3
Address pylint on line-too-long
pavoljuhas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove as well as other debugging code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will work on that