Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch circuit submit in cirq_ionq #6652

Merged
merged 17 commits into from
Nov 5, 2024

Conversation

radumarg
Copy link
Contributor

Enable batch circuit job submit in cirq_ionq

@CirqBot CirqBot added the size: XL lines changed >1000 label Jun 29, 2024
@github-actions github-actions bot added the Stale label Aug 1, 2024
@github-actions github-actions bot closed this Sep 1, 2024
@pavoljuhas pavoljuhas removed the Stale label Sep 4, 2024
@pavoljuhas pavoljuhas self-assigned this Sep 4, 2024
@mhucka mhucka reopened this Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 99.55654% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.85%. Comparing base (ac9cfe9) to head (7a51b3c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cirq-ionq/cirq_ionq/service.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6652    +/-   ##
========================================
  Coverage   97.84%   97.85%            
========================================
  Files        1081     1081            
  Lines       93015    93371   +356     
========================================
+ Hits        91011    91365   +354     
- Misses       2004     2006     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added Stale and removed Stale labels Oct 5, 2024
@pavoljuhas
Copy link
Collaborator

@radumarg , @spich - thank you for the reminder at today's csynque meeting.

Please resolve conflicts with the main branch and the CI-reported issues, then ping me so I can review ASAP.

@radumarg
Copy link
Contributor Author

@pavoljuhas Thanks for merging this. I fixed the merge issues but the CI issues indicated a bug in implementation, so I am still working on fixing it and extending unit tests.

@radumarg
Copy link
Contributor Author

radumarg commented Nov 4, 2024

@pavoljuhas The CI issues were fixed. A bug was fixed, tests have been updated. This ticket is ready for review.

No change in the effective code.
Let pylint check for `unexpected-keyword-arg`.
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this!

@pavoljuhas pavoljuhas enabled auto-merge (squash) November 5, 2024 01:01
@pavoljuhas pavoljuhas merged commit c0b8aed into quantumlib:main Nov 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: XL lines changed >1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants