Add Quantum Engine support for cirq.CZPowGate #6562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliottrosenberg
requested review from
NoureldinYosri,
senecameeks,
BichengYing and
dstrain115
eliottrosenberg
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6562 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 1124 1124
Lines 95489 95493 +4
=======================================
+ Hits 93380 93384 +4
Misses 2109 2109 ☔ View full report in Codecov by Sentry. |
BichengYing
reviewed
Apr 13, 2024
senecameeks
reviewed
Apr 15, 2024
| @@ -644,6 +679,7 @@ def test_to_proto(): | |||
| cirq.ops.FSimGate, tags_to_accept=[cirq_google.FSimViaModelTag()] | |||
| ): base_duration | |||
| * 10, | |||
| cirq.GateFamily(cirq.CZPowGate): base_duration * 11, | |||
There was a problem hiding this comment.
just to double check CZ will take 11ns, right?
There was a problem hiding this comment.
I was confused about this test until I stared at it for a while, so just pointing out a couple of things:
- These gate durations are arbitrary; take a look at lines 118-151, and you'll see that they are just arbitrary durations, and then the test compares them to
gate_durations = [(n, i * 1000) for i, n in enumerate(gate_names)](line 83). - In this test (not in real life), cz is given a duration of 3 ns (line 127).
NoureldinYosri
approved these changes
Apr 15, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
* Add Quantum Engine support for cirq.CZPowGate * build protos * update test * update test * add _CZ_POWER_GATE_FAMILY and keep _CZ_GATE_FAMILY * small revert to original * black * update test * update test * update test * add _CZ_POWER_TARGET_GATES * update target gateset * update test * update gatesets * update gatesets * update gatesets * update test * update test * update test * POW instead of POWER * POW instead of POWER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.