Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ctrl-M replacement controller for IBM Model M #24375

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

nuess0r
Copy link
Contributor

@nuess0r nuess0r commented Sep 9, 2024

Description

Adding keyboard definition to QMK for the ctrl-M replacement controller for IBM Model M keyboards.

Opening a new PR as the previous one got closed and can't be re-opened. Check here for the discussion history:
#22051

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Add a LAYOUT_all similar to other keyboards that defines all available keys.
Change the default keymap to use the _all layout so both ANSI and ISO Model M
variants work out of the box.
@nuess0r
Copy link
Contributor Author

nuess0r commented Oct 23, 2024

I updated the layout section with a _all layout (as other keybords do it as well) so I can ship the ctrl-M hardware with a firmware that supports US and non-US keyboards at the same time.

Brandon from Clickykeyboards has tested the ctrl-M successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant