-
-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ctrl-M replacement controller for IBM Model M #24375
Open
nuess0r
wants to merge
15
commits into
qmk:master
Choose a base branch
from
nuess0r:ctrl_m
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+467
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the keymaps/nuess0r how you can make better use of your Model M including Windows, multimedia keys etc.
Move layout definition from ctrl_m.h to info.json Move has_ghost to info.json -> this makes the config.h file obsolete
The nuess0r keymap which is shipped with the ctrl-M controller is kept here: https://github.com/nuess0r/qmk_firmware/tree/nuess0r_keymap
requested in review by drashna
Not pointing to the QMK firmware but to the replacement controller electronics project.
Will be moved to the https://github.com/the-via/qmk_userspace_via repo.
Add a LAYOUT_all similar to other keyboards that defines all available keys. Change the default keymap to use the _all layout so both ANSI and ISO Model M variants work out of the box.
I updated the layout section with a _all layout (as other keybords do it as well) so I can ship the ctrl-M hardware with a firmware that supports US and non-US keyboards at the same time. Brandon from Clickykeyboards has tested the ctrl-M successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding keyboard definition to QMK for the ctrl-M replacement controller for IBM Model M keyboards.
Opening a new PR as the previous one got closed and can't be re-opened. Check here for the discussion history:
#22051
Types of Changes
Issues Fixed or Closed by This PR
Checklist