Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added to the readme #24350

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added to the readme #24350

wants to merge 5 commits into from
+3 −0

Conversation

dawnshadow42
Copy link

@dawnshadow42 dawnshadow42 commented Sep 1, 2024 •
edited by zvecr
Loading

Description

The mf34 is now being sold with a different mcu than this was originally programmed for. The VID and PID have stayed the same, but once in DFU mode, they become different. Flashing with QMK Toolbox gives a device mismatch error. At the top of the readme I added how to find out which one you have, and the steps to flash if you have the newer (or knockoff?) Geehy chip.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr reviewed Sep 1, 2024
View reviewed changes
keyboards/magic_force/mf34/readme.md Outdated
@@ -1,3 +1,6 @@
# DEPENDING ON WHERE OR WHEN YOU PURCHASED THIS KEYBOARD, YOU MAY HAVE A DIFFERENT MCU AND BOOTLOADER THAN WHAT THIS FIRMWARE IS LOOKING FOR
Copy link
Member

@zvecr zvecr Sep 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be at the top of the file, also the suggestions for Geehy Programmer are redundant as you can still use dfu-util if the right DFU_ARGS are used.

Ideally none of this would be added, and either

  1. A new revision added with the correct apm32-dfu bootloader set
  2. The wildcard added that is on many other APM32F072 boards

filterpaper
filterpaper reviewed Sep 2, 2024
View reviewed changes
keyboards/magic_force/mf34/readme.md
Comment on lines +25 to +26
**Depending on where or when you bought this keyboard, you may have a different mcu and bootloader.**
This code was made for devices with the STM32F072 chip. Some are now being sold with the APM32F072 chip. The VID and PID on these variants are the same until put into DFU mode. There are 2 ways you find out which one you have. 1: you attempt to flash and get an error saying "device mismatch." 2: you open up the board and read "APM32F072 GEEHY" on the chip. If you have the Geehy chip, you should use dfu-util to flash your bin file or find and download Geehy Programmer and use that.
Copy link
Contributor

@filterpaper filterpaper Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they have switched to using APM clone, you can consider adding support for it using a suffix like #15414

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filterpaper filterpaper filterpaper left review comments

@zvecr zvecr zvecr left review comments

Assignees
No one assigned
Labels
keyboard stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawnshadow42 @zvecr @filterpaper