This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
fix: prevent user lock in and visually destructed list boxes on small devices #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielS-Qlik
approved these changes
Oct 10, 2023
johanlahti
added a commit
that referenced
this pull request
Nov 8, 2023
johanlahti
added a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Autofocus causes the browser to zoom in and cut off the UI.
…and on cancel (stuck in a listbox)
After
Zoom is reset on open… and not stuck on cancel.
Solution
There is no direct way of resetting the zoom. This solution uses a trick by (re-)setting the meta tag's scale when on small device.
In addition, the offset (top & left) introduced by the popover is now forced to stay at 0 so it does not go outside the viewport and locking in the user.