Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

refactor(filter-pane): adjust breakpoint for small-narrow and vertically align header #336

Merged
merged 9 commits into from
Aug 2, 2023
Merged

refactor(filter-pane): adjust breakpoint for small-narrow and vertically align header #336

merged 9 commits into from
Aug 2, 2023

Conversation

johanlahti
Copy link
Collaborator

@johanlahti johanlahti commented Aug 1, 2023 •
edited
Loading

Changes:

  • Adjust the small-narrow breakpoint so that it does not render an indicator only (and thus no field label visible) too soon:
    • narrowSmallLimit = 20px -> 16px
  • While doing this, we must align the header vertically by setting line-height to 100% instead of normal

@johanlahti johanlahti marked this pull request as draft August 1, 2023 09:57
@johanlahti johanlahti marked this pull request as ready for review August 1, 2023 14:31
@johanlahti johanlahti merged commit 28ee695 into main Aug 2, 2023
9 checks passed
@johanlahti johanlahti deleted the fix/adjust-narrow-small-size branch August 2, 2023 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@veinfors veinfors veinfors approved these changes

@quanho quanho Awaiting requested review from quanho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanlahti @veinfors