refactor: move collapse mode to presentation

qlik-oss · Aug 18, 2023 · 52174ba · 52174ba
1 parent f86837a
commit 52174ba
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 35 deletions.
diff --git a/packages/sn-filter-pane/src/ext/property-panel/data/data-panel/index.ts b/packages/sn-filter-pane/src/ext/property-panel/data/data-panel/index.ts
@@ -114,41 +114,11 @@ export default function getDataPanelItems(env: IEnv) {
         },
       },
     },
-    autoConfirmGroup: {
-      type: 'items',
-      grouped: true,
-      show() {
-        return env?.flags?.isEnabled('IM_4072_FILTERPANE_SETTINGS');
-      },
-      items: {
-        autoConfirm: {
-          ref: 'autoConfirm',
-          component: 'checkbox',
-          translation: 'properties.filterpane.autoConfirm',
-          defaultValue: false,
-        },
-      },
-    },
-    collapseMode: {
-      ref: 'collapseMode',
-      type: 'string',
-      component: 'buttongroup', // dropdown
-      translation: 'properties.filterpane.collapseMode',
-      defaultValue: 'auto',
-      options: [
-        {
-          value: 'auto',
-          translation: 'Common.Auto',
-        },
-        {
-          value: 'always',
-          translation: 'Common.Always',
-        },
-        {
-          value: 'never',
-          translation: 'Common.Never',
-        },
-      ],
+    autoConfirm: {
+      ref: 'autoConfirm',
+      component: 'checkbox',
+      translation: 'properties.filterpane.autoConfirm',
+      defaultValue: false,
       show() {
         return env?.flags?.isEnabled('IM_4072_FILTERPANE_SETTINGS');
       },

diff --git a/packages/sn-filter-pane/src/ext/property-panel/data/data-panel/presentation/index.ts b/packages/sn-filter-pane/src/ext/property-panel/data/data-panel/presentation/index.ts
@@ -106,6 +106,36 @@ export default function getPresentation(env: IEnv) {
           },
         },
       },
+      collapseModeGroup: {
+        type: 'items',
+        grouped: true,
+        show() {
+          return env?.flags?.isEnabled('IM_4072_FILTERPANE_SETTINGS');
+        },
+        items: {
+          collapseMode: {
+            ref: 'collapseMode',
+            type: 'string',
+            component: 'dropdown',
+            translation: 'properties.filterpane.collapseMode',
+            defaultValue: 'auto',
+            options: [
+              {
+                value: 'auto',
+                translation: 'Common.Auto',
+              },
+              {
+                value: 'always',
+                translation: 'Common.Always',
+              },
+              {
+                value: 'never',
+                translation: 'Common.Never',
+              },
+            ],
+          },
+        },
+      },
       gridModeGroup: {
         grouped: true,
         type: 'items',

diff --git a/types/global.d.ts b/types/global.d.ts
@@ -8,6 +8,7 @@ export interface IListLayout extends EngineAPI.IGenericListLayout {
     dense: boolean,
     dataLayout?: 'grid' | 'singleColumn',
   },
+  collapseMode?: 'auto' | 'always' | 'never';
   showTitle?: boolean,
   qHasSoftPatches?: boolean;
   qExtendsId?: string;