-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add right divider to listbox last column items #1222
Conversation
This looks odd. I expect us to want it for all items that are last in there row. not just the very last item. |
Right, will change this way. Edit: adding divider to the items of last column, see description |
Can you update the image in the description to show how it looks like with that fixed as well? |
Okey... No, that doesn't look good either, I would expect it to look like this ⬆️, but being correctly aligned (the last cell should have the same width as the other cells in that column that is) |
closing as it needs further alignment with UX |
Motivation
Add a right divider to all the items of the last column.
Not adding it to all last items of each row, as in that case will be mis-aligned with the left dividers of previous items in the same column.
Resolves qlik-oss/sn-list-objects#233
Screenshot with latest fix:
Requirements checklist
yarn spec
When build and tests have passed: