Merge pull request #71 from qlik-oss/DEB-244/ExcelRow

Suppress missing values and use correct cube size
qlik-oss · Jun 17, 2019 · 64b778b · 64b778b
2 parents be6718c + 4fab3b5
commit 64b778b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/dataset.js b/src/dataset.js
@@ -6,19 +6,19 @@ function createCube (definition, app) {
   });
 }
 
-async function buildDataCube (originCubeDefinition, hasTwoDimensions, app) {
+async function buildDataCube (originCubeDefinition, originCube, app) {
   const cubeDefinition = {
     ...originCubeDefinition,
     qInitialDataFetch: [
       {
-        qHeight: 1000,
-        qWidth: 10
+        qHeight: originCube.qSize.qcy,
+        qWidth: originCube.qSize.qcx
       }
     ],
     qDimensions: [originCubeDefinition.qDimensions[0]],
     qMeasures: originCubeDefinition.qMeasures
   };
-  if (hasTwoDimensions) {
+  if (originCube.qDimensionInfo.length === 2) {
     cubeDefinition.qDimensions.push(originCubeDefinition.qDimensions[1]);
   }
   const cube = await createCube(cubeDefinition, app);
@@ -42,7 +42,7 @@ export async function initializeDataCube (component, layout) {
   hyperCubeDef = JSON.parse(JSON.stringify(hyperCubeDef));
   hyperCubeDef.qStateName = layout.qStateName;
 
-  return buildDataCube(hyperCubeDef, layout.qHyperCube.qDimensionInfo.length === 2, app);
+  return buildDataCube(hyperCubeDef, layout.qHyperCube, app);
 }
 
 export function initializeDesignList (component, layout) {

diff --git a/src/index.js b/src/index.js
@@ -49,7 +49,9 @@ export default {
           qWidth: 10
         }
       ],
-      qMeasures: []
+      qMeasures: [],
+      qSuppressMissing: true,
+      qSuppressZero: false
     }
   },
   support: {