Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#396 - fixes to not fallback to GET #453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mii9000
Copy link

@mii9000 mii9000 commented Nov 8, 2021

No description provided.

@mii9000
Copy link
Author

mii9000 commented Nov 8, 2021

@qjebbs Would appreciate your review and release of a new version. I often encounter #396.

@qjebbs
Copy link
Owner

qjebbs commented Nov 11, 2021

why you don't want to fallback to GET?

@mii9000
Copy link
Author

mii9000 commented Nov 11, 2021

why you don't want to fallback to GET?

Because of the long URI issue when fallback to GET. That is what you mentioned in the issue comment right?
#396 (comment)

@qjebbs
Copy link
Owner

qjebbs commented Nov 11, 2021

  • If your server accepts POST, it won't fallback to GET.
  • If your server supports only GET, why shouldn't it fall back?

@mii9000
Copy link
Author

mii9000 commented Nov 11, 2021

But it does fallback to GET even if the server does support POST. For example, for me it works all fine until suddenly I get long URI error. Then I need to restart VS Code. Just like the original poster of the issue mentioned. Tell me what you are looking for in the PR and I will make the appropriate changes. Thanks.

@qjebbs
Copy link
Owner

qjebbs commented Nov 12, 2021

There are better ways than simply remove it, which may affect users who rely on it:

  1. find out why it fallback unexpectedly, improve it
  2. reverse the fallback logic, from fail once goto GET (blacklist) to success once stick to POST(whitelist)
  3. extend the setting logic, like POST http://host/path to force to use POST or GET

But...I don't have time to improve it😥

@qjebbs qjebbs force-pushed the master branch 2 times, most recently from 7194871 to 4a8cef3 Compare March 30, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants